fix: fix problem block offline generations

raccoongang · Jun 17, 2024 · 87393cd · 87393cd
1 parent 8f0a187
commit 87393cd
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/openedx/features/offline_mode/assets_management.py b/openedx/features/offline_mode/assets_management.py
@@ -58,7 +58,7 @@ def save_asset_file(temp_dir, xblock, path, filename):
             static_path = get_static_file_path(filename)
             content = read_static_file(static_path)
             file_path = os.path.join(temp_dir, 'assets', filename)
-    except (ItemNotFoundError, NotFoundError):
+    except (FileNotFoundError, ItemNotFoundError, NotFoundError):
         log.info(f"Asset not found: {filename}")
 
     else:

diff --git a/openedx/features/offline_mode/constants.py b/openedx/features/offline_mode/constants.py
@@ -9,7 +9,7 @@
 MATHJAX_CDN_URL = f'https://cdn.jsdelivr.net/npm/mathjax@{MATHJAX_VERSION}/MathJax.js'
 MATHJAX_STATIC_PATH = os.path.join('assets', 'js', f'MathJax-{MATHJAX_VERSION}.js')
 
-DEFAULT_OFFLINE_SUPPORTED_XBLOCKS = ['html']
+DEFAULT_OFFLINE_SUPPORTED_XBLOCKS = ['html', 'problem']
 OFFLINE_SUPPORTED_XBLOCKS = getattr(settings, 'OFFLINE_SUPPORTED_XBLOCKS', DEFAULT_OFFLINE_SUPPORTED_XBLOCKS)
 
 RETRY_BACKOFF_INITIAL_TIMEOUT = 60  # one minute

diff --git a/openedx/features/offline_mode/renderer.py b/openedx/features/offline_mode/renderer.py
@@ -81,7 +81,7 @@ def render_xblock_from_lms(self):
                 str(self.usage_key),
                 disable_staff_debug_info=True,
                 course=course,
-                will_recheck_access='1',
+                will_recheck_access=False,
             )
 
             enable_completion_on_view_service = False

diff --git a/openedx/features/offline_mode/tasks.py b/openedx/features/offline_mode/tasks.py
@@ -21,8 +21,10 @@ def generate_offline_content_for_course(course_id):
     course_key = CourseKey.from_string(course_id)
     for offline_supported_block_type in OFFLINE_SUPPORTED_XBLOCKS:
         for xblock in modulestore().get_items(course_key, qualifiers={'category': offline_supported_block_type}):
-            html_data = XBlockRenderer(str(xblock.location)).render_xblock_from_lms()
-            generate_offline_content_for_block.apply_async([str(xblock.location), html_data])
+            if hasattr(xblock, 'closed') and not xblock.closed():
+                block_id = str(xblock.location)
+                html_data = XBlockRenderer(block_id).render_xblock_from_lms()
+                generate_offline_content_for_block.apply_async([block_id, html_data])
 
 
 @shared_task(