forked from openedx/edx-platform
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [AXIMST-584] add correct icon for vertical block #2513
Merged
monteri
merged 2 commits into
ts-develop
from
Ivan_Niedielnitsev/AXIMST-584/bugfix/Create-endpoint-providing-Course-structure-for-sidebar
Mar 13, 2024
Merged
fix: [AXIMST-584] add correct icon for vertical block #2513
monteri
merged 2 commits into
ts-develop
from
Ivan_Niedielnitsev/AXIMST-584/bugfix/Create-endpoint-providing-Course-structure-for-sidebar
Mar 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monteri
reviewed
Mar 13, 2024
Comment on lines
+68
to
+80
@staticmethod | ||
def get_vertical_icon_class(block): | ||
""" | ||
Get the icon class for a vertical block based on its children. | ||
""" | ||
children = block.get('children', []) | ||
child_classes = {child.get('type') for child in children} | ||
new_class = 'other' | ||
icon_call_priority = ['video', 'problem'] | ||
for higher_class in icon_call_priority: | ||
if higher_class in child_classes: | ||
new_class = higher_class | ||
return new_class |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
@staticmethod | |
def get_vertical_icon_class(block): | |
""" | |
Get the icon class for a vertical block based on its children. | |
""" | |
children = block.get('children', []) | |
child_classes = {child.get('type') for child in children} | |
new_class = 'other' | |
icon_call_priority = ['video', 'problem'] | |
for higher_class in icon_call_priority: | |
if higher_class in child_classes: | |
new_class = higher_class | |
return new_class | |
@staticmethod | |
def get_vertical_icon_class(block, icon_mapping=None): | |
""" | |
Returns the icon class for a vertical block based on its children. | |
Args: | |
block (object): xblock object | |
Returns: | |
str: The icon class name to be used, or 'other' if no match is found. | |
""" | |
if icon_mapping is None: | |
icon_mapping = { | |
'video': 'video', | |
'problem': 'problem', | |
} | |
for child in block.get('children', []): | |
if child.get('type') in icon_mapping: | |
return icon_mapping[child.get('type')] | |
return 'other' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check if this passes as a solution
monteri
pushed a commit
that referenced
this pull request
Mar 13, 2024
* fix: [AXIMST-584] add correct icon for vertical block * style: [AXIMST-584] add missing docstring
ruzniaievdm
pushed a commit
that referenced
this pull request
Mar 28, 2024
* fix: [AXIMST-584] add correct icon for vertical block * style: [AXIMST-584] add missing docstring
ruzniaievdm
pushed a commit
that referenced
this pull request
Apr 4, 2024
* fix: [AXIMST-584] add correct icon for vertical block * style: [AXIMST-584] add missing docstring
monteri
pushed a commit
that referenced
this pull request
Apr 10, 2024
* fix: [AXIMST-584] add correct icon for vertical block * style: [AXIMST-584] add missing docstring
GlugovGrGlib
pushed a commit
that referenced
this pull request
Apr 12, 2024
* fix: [AXIMST-584] add correct icon for vertical block * style: [AXIMST-584] add missing docstring
monteri
pushed a commit
that referenced
this pull request
Apr 17, 2024
* fix: [AXIMST-584] add correct icon for vertical block * style: [AXIMST-584] add missing docstring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AXIMST-584 [BE] Create endpoint providing Course structure for sidebar