feat: [AXIMST-682] add caching for side navigation endpoint #2518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NiedielnitsevIvan
changed the title
monteri
reviewed
Mar 21, 2024
cms/djangoapps/contentstore/utils.py
Outdated
| Drop the course sidebar blocks cache for the given course. | ||
| """ | ||
| cache_key_prefix = f"course_sidebar_blocks_{course_id}" | ||
| all_cache_keys = cache.keys('*') |
There was a problem hiding this comment.
The only concern here is to retrieve all keys here. There can be many keys to load.
Could you check some potential improvements like:
def drop_course_sidebar_blocks_cache(course_id: str):
cache_key_prefix = f"course_sidebar_blocks_{course_id}"
for key in cache.iter_keys(f"{cache_key_prefix}*"):
cache.delete(key)
or
def drop_course_sidebar_blocks_cache(course_id: str):
cache_key_prefix = f"course_sidebar_blocks_{course_id}"
cache.delete_many(f"course_sidebar_blocks_{course_id}{key}" for key in cache.iter_keys(f"{cache_key_prefix}*"))
I assume that we have memcached and not redis and there can be limitations. Also I am glad to hear you thoughts on this
There was a problem hiding this comment.
It really is better that way, thank you)
I tried using the prefix with '*' in all method, but it didn't work that way.
Comment on lines
510
to
511
| for i, child in enumerate(block['children']): | ||
| block['children'][i] = self.mark_complete_recursive(child) |
There was a problem hiding this comment.
Suggested change
| for i, child in enumerate(block['children']): | |
| block['children'][i] = self.mark_complete_recursive(child) | |
| block['children'] = [self.mark_complete_recursive(child) for child in block['children']] |
is it better?
There was a problem hiding this comment.
Yep, thanks. Refactored
NiedielnitsevIvan
force-pushed
the
Ivan_Niedielnitsev/AXIMST-682/feature/Implement-caching-for-side-navigation-endpoint
branch
from
83c486f to
f33e171
Compare
monteri
approved these changes
Mar 22, 2024
monteri
pushed a commit
that referenced
this pull request
Mar 27, 2024
* feat: [AXIMST-682] add caching for side navigation endpoint * feat: [AXIMST-682] drop side navigation cache on course publishing * style: [AXIMST-682] fix code style * feat: [AXIMST-682] add waffle flag to enable/disable sidebar caching * feat: [AXIMST-682] exclude discussion blocks from completion calculation * refactor: [AXIMST-682] improvements after review
ruzniaievdm
pushed a commit
that referenced
this pull request
Mar 28, 2024
* feat: [AXIMST-682] add caching for side navigation endpoint * feat: [AXIMST-682] drop side navigation cache on course publishing * style: [AXIMST-682] fix code style * feat: [AXIMST-682] add waffle flag to enable/disable sidebar caching * feat: [AXIMST-682] exclude discussion blocks from completion calculation * refactor: [AXIMST-682] improvements after review
ruzniaievdm
pushed a commit
that referenced
this pull request
Apr 4, 2024
* feat: [AXIMST-682] add caching for side navigation endpoint * feat: [AXIMST-682] drop side navigation cache on course publishing * style: [AXIMST-682] fix code style * feat: [AXIMST-682] add waffle flag to enable/disable sidebar caching * feat: [AXIMST-682] exclude discussion blocks from completion calculation * refactor: [AXIMST-682] improvements after review
monteri
pushed a commit
that referenced
this pull request
Apr 10, 2024
* feat: [AXIMST-682] add caching for side navigation endpoint * feat: [AXIMST-682] drop side navigation cache on course publishing * style: [AXIMST-682] fix code style * feat: [AXIMST-682] add waffle flag to enable/disable sidebar caching * feat: [AXIMST-682] exclude discussion blocks from completion calculation * refactor: [AXIMST-682] improvements after review
GlugovGrGlib
pushed a commit
that referenced
this pull request
Apr 12, 2024
* feat: [AXIMST-682] add caching for side navigation endpoint * feat: [AXIMST-682] drop side navigation cache on course publishing * style: [AXIMST-682] fix code style * feat: [AXIMST-682] add waffle flag to enable/disable sidebar caching * feat: [AXIMST-682] exclude discussion blocks from completion calculation * refactor: [AXIMST-682] improvements after review
monteri
pushed a commit
that referenced
this pull request
Apr 17, 2024
* feat: [AXIMST-682] add caching for side navigation endpoint * feat: [AXIMST-682] drop side navigation cache on course publishing * style: [AXIMST-682] fix code style * feat: [AXIMST-682] add waffle flag to enable/disable sidebar caching * feat: [AXIMST-682] exclude discussion blocks from completion calculation * refactor: [AXIMST-682] improvements after review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: AXIMST-682 add caching for side navigation endpoint