feat: [AXM-53] add assertions for primary course #2522

NiedielnitsevIvan · 2024-03-28T18:02:45Z

feat: AXM-53 add assertions for primary course

monteri · 2024-03-29T16:22:23Z

lms/djangoapps/mobile_api/users/serializers.py

+            self.context.get('request'),
+            include_past_dates=True
+        )
+        next_assignment = {}


Suggested change

next_assignment = {}

next_assignment = None

Maybe we will declare it with None and return also return None if no future assignment?

monteri · 2024-03-29T16:24:53Z

lms/djangoapps/mobile_api/users/serializers.py

+            include_past_dates=True
+        )
+        next_assignment = {}
+        past_assignment = []


Suggested change

past_assignment = []

past_assignments = [assignment for assignment in sorted_assignments if assignment.date < datetime.now(timezone)]

If we iterate over the same list twice the complexity will be O(2N) that is by O-notation roughly the same as a single iteration.

What benefits will this give us, since this way we will iterate by sorted_assignments 2 times? In addition, we will also worsen the readability, as for me.

monteri · 2024-03-29T16:29:48Z

lms/djangoapps/mobile_api/users/serializers.py

+        )
+        next_assignment = {}
+        past_assignment = []
+


Suggested change

sorted_assignments = sorted(assignments, key=lambda x: x.date)

create this variable and move it above the past assignments

Do we need this micro-optimization here if there is still only one cycle?

monteri · 2024-03-29T16:29:51Z

lms/djangoapps/mobile_api/users/serializers.py

+        for assignment in sorted(assignments, key=lambda x: x.date):
+            if assignment.date < datetime.now(timezone):
+                past_assignment.append(assignment)
+            else:
+                if not next_assignment:
+                    next_assignment = DateSummarySerializer(assignment).data


Suggested change

for assignment in sorted(assignments, key=lambda x: x.date):

if assignment.date < datetime.now(timezone):

past_assignment.append(assignment)

else:

if not next_assignment:

next_assignment = DateSummarySerializer(assignment).data

for assignment in sorted_assignments:

if assignment.date >= datetime.now(timezone):

next_assignment = DateSummarySerializer(assignment).data

break

* feat: [AXM-53] add assertions for primary course * test: [AXM-53] fix tests * style: [AXM-53] change future_assignment default value to None * refactor: [AXM-53] add some optimization for assignments collecting

* feat: [AXM-24] Update structure for course enrollments API (#2515) * feat: [AXM-24] Update structure for course enrollments API * style: [AXM-24] Improve code style * fix: [AXM-24] Fix student's latest enrollment filter * feat: [AXM-47] Add course_status field to primary object (#2517) * feat: [AXM-40] add courses progress to enrollment endpoint (#2519) * fix: workaround for staticcollection introduced in e40a01c * feat: [AXM-40] add courses progress to enrollment endpoint * refactor: [AXM-40] add caching to improve performance * refactor: [AXM-40] add progress only for primary course * refactor: [AXM-40] refactor enrollment caching optimization --------- Co-authored-by: Glib Glugovskiy <[email protected]> * feat: [AXM-53] add assertions for primary course (#2522) * feat: [AXM-53] add assertions for primary course * test: [AXM-53] fix tests * style: [AXM-53] change future_assignment default value to None * refactor: [AXM-53] add some optimization for assignments collecting * feat: [AXM-200] Implement user's enrolments status API * style: [AXM-200] Improve code style * refactor: [AXM-200] Divide get method into smaller methods --------- Co-authored-by: NiedielnitsevIvan <[email protected]> Co-authored-by: Glib Glugovskiy <[email protected]>