chore: define OriginalSquareSize inside generateRandomBlockData (c…

…elestiaorg#717)

* test: specify square size

* move location of square size declaration

pkg/shares/shares_test.go

@@ -224,7 +224,6 @@ func TestMerge(t *testing.T) {
 				tc.msgCount,
 				tc.maxSize,
 			)
-			data.OriginalSquareSize = appconsts.MaxSquareSize
 
 			rawShares, err := Split(data, false)
 			require.NoError(t, err)
@@ -275,12 +274,12 @@ func TestFuzz_Merge(t *testing.T) {
 }
 
 // generateRandomBlockData returns randomly generated block data for testing purposes
-func generateRandomBlockData(txCount, evdCount, msgCount, maxSize int) coretypes.Data {
-	var out coretypes.Data
-	out.Txs = generateRandomlySizedCompactShares(txCount, maxSize)
-	out.Evidence = generateIdenticalEvidence(evdCount)
-	out.Messages = generateRandomlySizedMessages(msgCount, maxSize)
-	return out
+func generateRandomBlockData(txCount, evdCount, msgCount, maxSize int) (data coretypes.Data) {
+	data.Txs = generateRandomlySizedCompactShares(txCount, maxSize)
+	data.Evidence = generateIdenticalEvidence(evdCount)
+	data.Messages = generateRandomlySizedMessages(msgCount, maxSize)
+	data.OriginalSquareSize = appconsts.MaxSquareSize
+	return data
 }
 
 func generateRandomlySizedCompactShares(count, max int) coretypes.Txs {