refacto: tell dont ask

typescript/package.json

@@ -5,7 +5,8 @@
   "scripts": {
     "lint": "eslint . --ext .ts",
     "lint-fix": "eslint . --ext .ts --fix",
-    "test": "jest"
+    "test": "jest",
+    "test:watch": "jest --watch"
   },
   "devDependencies": {
     "@types/node": "^12.12",

typescript/src/domain/Category.ts

@@ -3,19 +3,19 @@ class Category {
   private taxPercentage: number;
 
   public getName(): string {
-      return this.name;
+    return this.name;
   }
 
   public setName(name: string): void {
-      this.name = name;
+    this.name = name;
   }
 
   public getTaxPercentage(): number {
-      return this.taxPercentage;
+    return this.taxPercentage;
   }
 
   public setTaxPercentage(taxPercentage: number) {
-      this.taxPercentage = taxPercentage;
+    this.taxPercentage = taxPercentage;
   }
 }
 

typescript/src/domain/Order.ts

@@ -1,5 +1,10 @@
 import OrderItem from './OrderItem';
-import { OrderStatus } from './OrderStatus';
+import {OrderStatus} from './OrderStatus';
+import ShippedOrdersCannotBeChangedException from '../exception/ShippedOrdersCannotBeChangedException';
+import RejectedOrderCannotBeApprovedException from '../exception/RejectedOrderCannotBeApprovedException';
+import ApprovedOrderCannotBeRejectedException from '../exception/ApprovedOrderCannotBeRejectedException';
+import OrderCannotBeShippedTwiceException from '../exception/OrderCannotBeShippedTwiceException';
+import OrderCannotBeShippedException from '../exception/OrderCannotBeShippedException';
 
 class Order {
   private total: number;
@@ -9,52 +14,94 @@ class Order {
   private status: OrderStatus;
   private id: number;
 
-  public getTotal(): number {
-      return this.total;
+  constructor() {
+    this.total = 0;
+    this.currency = 'EUR';
+    this.items = [];
+    this.tax = 0;
+    this.status = OrderStatus.CREATED;
+    this.id = Math.floor(Math.random() * 1000000);
   }
 
-  public setTotal(total: number): void  {
-      this.total = total;
+  public getTotal(): number {
+    return this.total;
   }
 
   public getCurrency(): string {
-      return this.currency;
+    return this.currency;
   }
 
-  public setCurrency(currency: string): void {
-      this.currency = currency;
+  public getItems(): OrderItem[] {
+    return this.items;
   }
 
-  public getItems(): OrderItem[] {
-      return this.items;
+  public getTax(): number {
+    return this.tax;
   }
 
-  public setItems(items: OrderItem[]): void {
-      this.items = items;
+  public getStatus(): OrderStatus {
+    return this.status;
   }
 
-  public getTax(): number {
-      return this.tax;
+  public setStatus(status: OrderStatus): void {
+    this.status = status;
   }
 
-  public setTax(tax: number): void {
-      this.tax = tax;
+  public getId(): number {
+    return this.id;
   }
 
-  public getStatus(): OrderStatus {
-      return this.status;
+  public addItem(item: OrderItem): void {
+    this.items.push(item);
+
+    this.total += item.getTaxedAmount();
+    this.tax += item.getTax();
   }
 
-  public setStatus(status: OrderStatus): void {
-      this.status = status;
+  public approve(): void {
+    if (this.isShipped()) {
+      throw new ShippedOrdersCannotBeChangedException();
+    } else if (this.isRejected()) {
+      throw new RejectedOrderCannotBeApprovedException();
+    } else {
+      this.status = OrderStatus.APPROVED;
+    }
   }
 
-  public getId(): number {
-      return this.id;
+  public reject(): void {
+    if (this.isShipped()) {
+      throw new ShippedOrdersCannotBeChangedException();
+    } else if (this.isApproved()) {
+      throw new ApprovedOrderCannotBeRejectedException();
+    } else {
+      this.status = OrderStatus.REJECTED;
+    }
+  }
+
+  public canBeShipped(): void {
+    if (this.isShipped()) {
+      throw new OrderCannotBeShippedTwiceException();
+    }
+
+    if (!this.isApproved()) {
+      throw new OrderCannotBeShippedException();
+    }
+  }
+
+  public ship(): void {
+    this.status = OrderStatus.SHIPPED;
+  }
+
+  public isRejected(): boolean {
+    return this.status === OrderStatus.REJECTED;
+  }
+
+  public isApproved(): boolean {
+    return this.status === OrderStatus.APPROVED;
   }
 
-  public setId(id: number): void {
-      this.id = id;
+  public isShipped(): boolean {
+    return this.status === OrderStatus.SHIPPED;
   }
 }
 

typescript/src/domain/OrderItem.ts

@@ -1,21 +1,25 @@
 import Product from './Product';
+import SellItemRequest from '../request/SellItemRequest';
 
 class OrderItem {
-  private product: Product;
+  private readonly product: Product;
   private quantity: number;
-  private taxedAmount: number;
-  private tax: number;
+  private readonly taxedAmount: number;
+  private readonly tax: number;
 
-  public getProduct(): Product {
-    return this.product;
+  constructor(product: Product, itemRequest: SellItemRequest) {
+    this.product = product;
+    this.quantity = itemRequest.getQuantity();
+    this.tax = product.getUnitaryTax() * this.quantity;
+    this.taxedAmount = product.getUnitaryTaxedAmount() * this.quantity;
   }
 
-  public setProduct(product: Product): void {
-    this.product = product;
+  public getProduct(): Product {
+    return this.product;
   }
 
   public getQuantity(): number {
-      return this.quantity;
+    return this.quantity;
   }
 
   public setQuantity(quantity: number): void {
@@ -26,17 +30,9 @@ class OrderItem {
     return this.taxedAmount;
   }
 
-  public setTaxedAmount(taxedAmount: number): void {
-    this.taxedAmount = taxedAmount;
-  }
-
   public getTax(): number {
     return this.tax;
   }
-
-  public setTax(tax: number): void {
-    this.tax = tax;
-  }
 }
 
 export default OrderItem;

typescript/src/domain/Product.ts

@@ -28,6 +28,14 @@ class Product {
   public setCategory(category: Category): void {
     this.category = category;
   }
+
+  public getUnitaryTax(): number {
+    return Math.round(this.getPrice() / 100 * this.getCategory().getTaxPercentage() * 100) / 100;
+  }
+
+  public getUnitaryTaxedAmount(): number {
+    return Math.round((this.getPrice() + this.getUnitaryTax()) * 100) / 100;
+  }
 }
 
 export default Product;

typescript/src/useCase/OrderShipmentRequest.ts → typescript/src/request/OrderShipmentRequest.ts

@@ -2,11 +2,11 @@ class OrderShipmentRequest {
   private orderId: number;
 
   public setOrderId(orderId: number): void {
-      this.orderId = orderId;
+    this.orderId = orderId;
   }
 
   public getOrderId(): number {
-      return this.orderId;
+    return this.orderId;
   }
 }
 

typescript/src/useCase/SellItemRequest.ts → typescript/src/request/SellItemRequest.ts

@@ -3,19 +3,19 @@ class SellItemRequest {
   private productName: string;
 
   public setQuantity(quantity: number): void{
-      this.quantity = quantity;
+    this.quantity = quantity;
   }
 
   public setProductName(productName: string): void {
-      this.productName = productName;
+    this.productName = productName;
   }
 
   public getQuantity(): number {
-      return this.quantity;
+    return this.quantity;
   }
 
   public getProductName(): string {
-      return this.productName;
+    return this.productName;
   }
 }
 

typescript/src/useCase/SellItemsRequest.ts → typescript/src/request/SellItemsRequest.ts

@@ -1,10 +1,10 @@
-import SellItemRequest from "./SellItemRequest";
+import SellItemRequest from './SellItemRequest';
 
 class SellItemsRequest {
   private requests: SellItemRequest[];
 
   public setRequests(requests: SellItemRequest[]): void {
-      this.requests = requests;
+    this.requests = requests;
   }
 
   public getRequests(): SellItemRequest[] {

typescript/src/service/ShipmentService.ts

@@ -1,5 +1,5 @@
 import Order from '../domain/Order';
 
 export interface ShipmentService {
-    ship(order: Order): void;
+  ship(order: Order): void;
 }

typescript/src/useCase/OrderApprovalUseCase.ts

@@ -1,36 +1,25 @@
 import Order from '../domain/Order';
-import { OrderStatus } from '../domain/OrderStatus';
 import OrderRepository from '../repository/OrderRepository';
-import ApprovedOrderCannotBeRejectedException from './ApprovedOrderCannotBeRejectedException';
-import OrderApprovalRequest from './OrderApprovalRequest';
-import RejectedOrderCannotBeApprovedException from './RejectedOrderCannotBeApprovedException';
-import ShippedOrdersCannotBeChangedException from './ShippedOrdersCannotBeChangedException';
+import OrderApprovalRequest from '../request/OrderApprovalRequest';
 
 class OrderApprovalUseCase {
   private readonly orderRepository: OrderRepository;
 
-  public constructor(orderRepository: OrderRepository){
-      this.orderRepository = orderRepository;
+  public constructor(orderRepository: OrderRepository) {
+    this.orderRepository = orderRepository;
   }
 
   public run(request: OrderApprovalRequest): void {
-      const order: Order = this.orderRepository.getById(request.getOrderId());
+    const order: Order = this.orderRepository.getById(request.getOrderId());
 
-      if (order.getStatus() === OrderStatus.SHIPPED) {
-          throw new ShippedOrdersCannotBeChangedException();
-      }
+    if (request.isApproved()) {
+      order.approve();
+    } else {
+      order.reject();
+    }
 
-      if (request.isApproved() && order.getStatus() === OrderStatus.REJECTED) {
-          throw new RejectedOrderCannotBeApprovedException();
-      }
-
-      if (!request.isApproved() && order.getStatus() === OrderStatus.APPROVED) {
-          throw new ApprovedOrderCannotBeRejectedException();
-      }
-
-      order.setStatus(request.isApproved() ? OrderStatus.APPROVED : OrderStatus.REJECTED);
-      this.orderRepository.save(order);
+    this.orderRepository.save(order);
   }
 }
 
-export default OrderApprovalUseCase
+export default OrderApprovalUseCase;

typescript/src/useCase/OrderCreationUseCase.ts

@@ -1,11 +1,10 @@
 import Order from '../domain/Order';
 import OrderItem from '../domain/OrderItem';
-import { OrderStatus } from '../domain/OrderStatus';
 import Product from '../domain/Product';
 import OrderRepository from '../repository/OrderRepository';
-import { ProductCatalog } from '../repository/ProductCatalog';
-import SellItemsRequest from './SellItemsRequest';
-import UnknownProductException from './UnknownProductException';
+import {ProductCatalog} from '../repository/ProductCatalog';
+import SellItemsRequest from '../request/SellItemsRequest';
+import UnknownProductException from '../exception/UnknownProductException';
 
 class OrderCreationUseCase {
   private readonly orderRepository: OrderRepository;
@@ -18,33 +17,14 @@ class OrderCreationUseCase {
 
   public run(request: SellItemsRequest): void {
     const order: Order = new Order();
-    order.setStatus(OrderStatus.CREATED);
-    order.setItems([]);
-    order.setCurrency('EUR');
-    order.setTotal(0);
-    order.setTax(0);
 
     for (const itemRequest of request.getRequests()) {
-       const product: Product = this.productCatalog.getByName(itemRequest.getProductName());
+      const product: Product = this.productCatalog.getByName(itemRequest.getProductName());
 
       if (product === undefined) {
         throw new UnknownProductException();
-      }
-      else {
-        const unitaryTax: number = Math.round(product.getPrice() / 100 * product.getCategory().getTaxPercentage() * 100) / 100;
-        const unitaryTaxedAmount: number = Math.round((product.getPrice() + unitaryTax) * 100) / 100;
-        const taxedAmount: number = Math.round(unitaryTaxedAmount * itemRequest.getQuantity() * 100) / 100;
-        const taxAmount: number = unitaryTax * itemRequest.getQuantity();
-
-        const orderItem: OrderItem = new OrderItem();
-        orderItem.setProduct(product);
-        orderItem.setQuantity(itemRequest.getQuantity());
-        orderItem.setTax(taxAmount);
-        orderItem.setTaxedAmount(taxedAmount);
-        order.getItems().push(orderItem);
-
-        order.setTotal(order.getTotal() + taxedAmount);
-        order.setTax(order.getTax() + taxAmount);
+      } else {
+        order.addItem(new OrderItem(product, itemRequest));
       }
     }