fix(neutron): require nautobot auth and provide it by default #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 0d435bd these config options must be supplied for the server to start up successfully.
The neutron token isn't defined here but has been used from the nautobot-token that is defined in the workflows which isn't good for separation. Since 0d435bd the loading of the token from the file no longer works so we must load it via a config snippet. This defines a new secret that creates a config snippet with the token. The same change also dropped the default URL for the Nautobot service within the cluster so this defines that value as well.
skrobul
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The config option parser was not requiring the nautobot auth info which was no longer defaulted or read from the existing location as of #666. This makes it required for the server to start up successfully. Lastly the auth information was actually being read from a location supplied by the workflows so create a new secret with the data populated. Create the secret in the syntax of a config snippet for oslo.config to automatically pick up for us and load in.