add in, contains, and MembershipTestable
#615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usaoc
reviewed
Jan 19, 2025
|
Bikeshedding: |
Add an `in` operator that tests membership as in many other languages (e.g., Python, Kotlin, Rust). The operator combination `!in` works because `!` now has an infix mode as long as its followed by `in`, `is_now` or `is_a`. A new class can support `in` by implementing the `MembershipTestable` interface, which has a single `contains` method. The method is required to return a `Boolean`. Rename `List.has_element` and `Range.has_element` to `List.contains` and `Range.contains`. Add `Array.contains`, `Map.contains` (an alias for `Map.has_key`), and `Set.contains`. Change sets to be non-indexable. The former indexing operation on a set is better expressed using `in`. Mutable sets no longer have an operator form for assignment; `MutableSet.add` or `MutableSet.remove` must be used, instead. While we're at it, add `Set.add`, rename `MutableMap.delete` to `MutableMap.remove`, and rename `MutableSet.delete` to `MutableSet.remove`.
Similar to the way `def` allows `=` in place of `:`, allow `in` in
place of `:` for `each` bindings:
```
for (i in 0..10):
println(i)
for:
each i in 0..10
println(i)
```
Change tests and docs to use `in` as the preferred form for `each`.
|
I agree that Conversion to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an
inoperator that tests membership as in many other languages (e.g., Python, Kotlin, Rust). The operator combination!inworks because!now has an infix mode as long as its followed byin,is_noworis_a.A new class can support
inby implementing theMembershipTestableinterface, which has a singlecontainsmethod. The method is required to return aBoolean.Rename
List.has_elementandRange.has_elementtoList.containsandRange.contains. AddArray.contains,Map.contains(an alias forMap.has_key), andSet.contains.Change sets to be non-indexable. The former indexing operation on a set is better expressed using
in. Mutable sets no longer have an operator form for assignment;MutableSet.addorMutableSet.removemust be used, instead.While we're at it, add
Set.add, renameMutableMap.deletetoMutableMap.remove, and renameMutableSet.deletetoMutableSet.remove.