Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/python version upgrades #2030

Merged
merged 18 commits into from
Dec 4, 2023
Merged

Conversation

jake-skipper
Copy link
Contributor

@jake-skipper jake-skipper commented Dec 4, 2023

Summary

This PR does the following:

  1. Updates the pipeline functions to use Python 3.9 or greater as 3.8 is going to be EOL soon,
  2. Adds pipeline support for Python 3.11,
  3. Updates away from ubuntu-20.04 runner type to ubuntu-latest; and,
  4. A few tweaks to make the pipeline work in a 3.9 environment.

Why This Is Needed

Python 3.8 is going EOL and we may as well loop in an Ubuntu runner update while we're making all the changes. This will hopefully keep the pipeline going a bit longer without a complete refactor.

NOTE: There are still some areas where Python 3.8 references were left in place, namely awslambda testing within the tool. I have gone ahead and left these for now as they depend on lambci images which have not been updated to support past 3.8, and AWS still supports 3.8 for a time. Will open issues for these problems separately.

Checklist

  • Have you followed the guidelines in our Contribution Requirements?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Does your submission pass tests?
  • Have you linted your code locally prior to submission?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?
  • Have you updated documentation, as applicable?

@github-actions github-actions bot added feature Request or pull request for a new feature github_actions Update to GitHub Actions poetry Update to Poetry configuration python Update to Python code labels Dec 4, 2023
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Merging #2030 (28018e8) into master (7f2db9f) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2030   +/-   ##
=======================================
  Coverage   90.18%   90.18%           
=======================================
  Files         247      247           
  Lines       15681    15681           
=======================================
  Hits        14142    14142           
  Misses       1539     1539           
Files Coverage Δ
runway/_logging.py 95.65% <100.00%> (ø)
runway/cfngin/hooks/aws_lambda.py 84.81% <100.00%> (ø)
runway/cfngin/hooks/awslambda/models/args.py 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f2db9f...28018e8. Read the comment docs.

@jake-skipper jake-skipper merged commit 6ad49bb into master Dec 4, 2023
@jake-skipper jake-skipper deleted the feature/python-version-upgrades branch December 4, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Request or pull request for a new feature github_actions Update to GitHub Actions poetry Update to Poetry configuration python Update to Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants