-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/python version upgrades #2030
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2030 +/- ##
=======================================
Coverage 90.18% 90.18%
=======================================
Files 247 247
Lines 15681 15681
=======================================
Hits 14142 14142
Misses 1539 1539
Continue to review full report in Codecov by Sentry.
|
mbordash2
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature
Request or pull request for a new feature
github_actions
Update to GitHub Actions
poetry
Update to Poetry configuration
python
Update to Python code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR does the following:
ubuntu-20.04
runner type toubuntu-latest
; and,Why This Is Needed
Python 3.8 is going EOL and we may as well loop in an Ubuntu runner update while we're making all the changes. This will hopefully keep the pipeline going a bit longer without a complete refactor.
NOTE: There are still some areas where Python 3.8 references were left in place, namely
awslambda
testing within the tool. I have gone ahead and left these for now as they depend onlambci
images which have not been updated to support past 3.8, and AWS still supports 3.8 for a time. Will open issues for these problems separately.Checklist