Fix iS. paddr vaddr confusion ##core #22674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
draft, i'm going to check the tests soon |
This change removes the part of the `printHere` address check where it explicitly checked for `paddr` even if the paddr / vaddr dichotomy is already handled via the `addr` variable, which is the only one we have to check here. That caused wrong behaviour in binaries where the vaddr and paddr space numerically overlap (like old DOS/4GW LE binaries) where `iS.` was in fact picking the `paddr` instead of `vaddr` to filter if such an entry came first in the list.
mrmacete
force-pushed
the
fix/sections-paddr-vaddr-here
branch
from
cf94579 to
57be3c9
Compare
|
new test needs radareorg/radare2-testbins#94 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change removes the part of the
printHereaddress check where it explicitly checked forpaddreven if the paddr / vaddr dichotomy is already handled via theaddrvariable, which is the only one we have to check here.That caused wrong behaviour in binaries where the vaddr and paddr space numerically overlap (like old DOS/4GW LE binaries) where
iS.was in fact picking thepaddrinstead ofvaddrto filter if such an entry came first in the list.