Use monkeypatch

radarhere · Dec 28, 2024 · 1c97cc9 · 1c97cc9
1 parent b285979
commit 1c97cc9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 12 deletions.
diff --git a/Tests/test_file_png.py b/Tests/test_file_png.py
@@ -772,23 +772,19 @@ def test_seek(self) -> None:
                 im.seek(1)
 
     @pytest.mark.parametrize("buffer", (True, False))
-    def test_save_stdout(self, buffer: bool) -> None:
-        old_stdout = sys.stdout
+    def test_save_stdout(self, buffer: bool, monkeypatch: pytest.MonkeyPatch) -> None:
         b = BytesIO()
 
         class MyStdOut:
             buffer = b
 
         mystdout = cast(BytesIO, MyStdOut()) if buffer else b
 
-        sys.stdout = mystdout
+        monkeypatch.setattr(sys, "stdout", mystdout)
 
         with Image.open(TEST_PNG_FILE) as im:
             im.save(sys.stdout, "PNG")
 
-        # Reset stdout
-        sys.stdout = old_stdout
-
         with Image.open(b) as reloaded:
             assert_image_equal_tofile(reloaded, TEST_PNG_FILE)
 

diff --git a/Tests/test_file_ppm.py b/Tests/test_file_ppm.py
@@ -368,22 +368,18 @@ def test_mimetypes(tmp_path: Path) -> None:
 
 
 @pytest.mark.parametrize("buffer", (True, False))
-def test_save_stdout(buffer: bool) -> None:
-    old_stdout = sys.stdout
+def test_save_stdout(buffer: bool, monkeypatch: pytest.MonkeyPatch) -> None:
     b = BytesIO()
 
     class MyStdOut:
         buffer = b
 
     mystdout = cast(BytesIO, MyStdOut()) if buffer else b
 
-    sys.stdout = mystdout
+    monkeypatch.setattr(sys, "stdout", mystdout)
 
     with Image.open(TEST_FILE) as im:
         im.save(sys.stdout, "PPM")
 
-    # Reset stdout
-    sys.stdout = old_stdout
-
     with Image.open(b) as reloaded:
         assert_image_equal_tofile(reloaded, TEST_FILE)