fix byte-compilation #1109
Merged
fix byte-compilation #1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, normal-top-level-add-subdirs-to-load-path was not adding the subdirs to the front of the load-path. This can lead to a built-in package shadowing the version in straight/build/ during compilation, which can result in mixed compilations and subsequent runtime errors. See: radian-software#1107
|
@progfolio shouldn't this get merged into master. This is a pretty significant bug, IMO. |
Merged to master. Testing is appreciated. |
|
FWIW, it did fix the issue for me. |
|
@progfolio I'm not sure if this is related, but this issue has reemerged for me in a very consistent way for me now today: Seems like this change might be related, but I haven't had time to look in to it deeply yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.