safer srun termination

[andre-merzky]

This fixes #3267

[mtitov]

@andre-merzky quick check - should we add some handling of the termination signal within the launching script? do we need to preserve launch_collect tracing event? or such tasks will finish with task_run_cancel_stop only?

[andre-merzky]

@andre-merzky quick check - should we add some handling of the termination signal within the launching script? do we need to preserve launch_collect tracing event? or such tasks will finish with task_run_cancel_stop only?

A launch script handler would, IMHO, only make sense if we want to still execute post_launch commands - which I don't think should happen. We can't do much about the exec script anyway, and that's where the interesting parts are. So indeed, I would expect task_run_cancel_stop to be the next event in this case.

[mtitov]

Thanks Andre!

[mtitov]

LGTM!

[andre-merzky]

Oh, I need to fix the tests... Will do ASAP.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.84%. Comparing base (ec79ef6) to head (d549958).
Report is 7 commits behind head on devel.

Additional details and impacted files

@@            Coverage Diff             @@
##            devel    #3270      +/-   ##
==========================================
+ Coverage   42.80%   42.84%   +0.04%     
==========================================
  Files          97       97              
  Lines       11254    11262       +8     
==========================================
+ Hits         4817     4825       +8     
  Misses       6437     6437              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.