chore: add model_type validations #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| print " "; | ||
| print "#### Generated by tools/update-authors.sh.\n"; | ||
| } | ||
| ' > AUTHORS.md |
There was a problem hiding this comment.
Just a question:
I think that AUTHORS.md file is not going to be automatically updated on git repo without git commit and git push, am i wrong?
There was a problem hiding this comment.
Only after a PR push on main branch...if Actions works :-D
rivamarco
reviewed
Jul 1, 2024
rivamarco
reviewed
Jul 1, 2024
rivamarco
reviewed
Jul 1, 2024
dtria91
reviewed
Jul 1, 2024
| return value in (None, SupportedTypes.float) | ||
|
|
||
|
|
||
| def is_none(value: Any) -> bool: |
There was a problem hiding this comment.
value: Optional[SupportedTypes]
There was a problem hiding this comment.
In that case I'm not agree with you, value could be Any because this utils is general purpose
dtria91
reviewed
Jul 1, 2024
dtria91
reviewed
Jul 1, 2024
lorenzodagostinoradicalbit
approved these changes
Jul 1, 2024
dtria91
approved these changes
Jul 1, 2024
maocorte
pushed a commit
that referenced
this pull request
Jul 16, 2024
* chore: add model_type validations * chore: add model_type validations * doc: postgres installation required for local test * chore: add authors.md and its related automation script * chore: add a Github Actions in order to automate update-authors.sh executions * chore: refactoring tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR several validators have been applied to ModelIn class.