Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set correlation id column as optional #88

Merged
merged 2 commits into from
Jul 8, 2024
Merged

fix: set correlation id column as optional #88

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e0c0d9
fix: set correlation_id as optional value
dtria91 Jul 8, 2024
a1fae71
fix: sdk - set correlation id field as optional
dtria91 Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: sdk - set correlation id field as optional
  • Loading branch information
@dtria91
dtria91 committed Jul 8, 2024
commit a1fae71d01cd36dd1d3a27bade2d1a3a738d56e7
7 changes: 4 additions & 3 deletions sdk/radicalbit_platform_sdk/apis/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ def load_current_dataset(
self,
file_name: str,
bucket: str,
correlation_id_column: str,
correlation_id_column: Optional[str] = None,
object_name: Optional[str] = None,
aws_credentials: Optional[AwsCredentials] = None,
separator: str = ',',
Expand All @@ -307,7 +307,8 @@ def load_current_dataset(
).columns.tolist()

required_headers = self.__required_headers()
required_headers.append(correlation_id_column)
if correlation_id_column:
required_headers.append(correlation_id_column)
required_headers.append(self.__timestamp.name)

if set(required_headers).issubset(file_headers):
Expand Down Expand Up @@ -465,7 +466,7 @@ def __bind_current_dataset(
self,
dataset_url: str,
separator: str,
correlation_id_column: str,
correlation_id_column: Optional[str] = None,
) -> ModelCurrentDataset:
def __callback(response: requests.Response) -> ModelCurrentDataset:
try:
Expand Down
2 changes: 1 addition & 1 deletion sdk/radicalbit_platform_sdk/apis/model_current_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def uuid(self) -> UUID:
def path(self) -> str:
return self.__path

def correlation_id_column(self) -> str:
def correlation_id_column(self) -> Optional[str]:
return self.__correlation_id_column

def date(self) -> str:
Expand Down
2 changes: 1 addition & 1 deletion sdk/radicalbit_platform_sdk/models/file_upload_result.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class ReferenceFileUpload(FileUploadResult):


class CurrentFileUpload(FileUploadResult):
correlation_id_column: str
correlation_id_column: Optional[str] = None

model_config = ConfigDict(populate_by_name=True, alias_generator=to_camel)

Expand Down