This repository has been archived by the owner on May 11, 2023. It is now read-only.
issue: TUI #172
Open
issue: TUI #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 16, 2022
Closed
cloudhead
reviewed
Oct 7, 2022
| pub struct CommentList<R> { | ||
| props: Props, | ||
| comments: ListState<Comment<R>>, | ||
| } |
There was a problem hiding this comment.
// before
SpecificListComponent<R> {
state: GenericState<Specific<R>>
}
// after
GenericList<ChildComponent> {
children: Vec<ChildComponent>,
state: SpecificState
}There was a problem hiding this comment.
I'm not sure this will work since every component must provide a component-specific implementation of Component in order to receive events: https://github.com/radicle-dev/radicle-cli/pull/172/files#diff-dcbc1cad867aa6da05adc9efaa047bda13bfcdf930b86e9b17bcb8544163eb1bR365.
They usually call self.perform() which would need to generate component-specific command results like "index changed in issue list". Might need to experiment with a generic implementation and see if that would fit in.
Signed-off-by: Erik Kundt <[email protected]>
Signed-off-by: Erik Kundt <[email protected]>
Signed-off-by: Erik Kundt <[email protected]>
Signed-off-by: Erik Kundt <[email protected]>
Signed-off-by: Erik Kundt <[email protected]>
Signed-off-by: Erik Kundt <[email protected]>
Signed-off-by: Erik Kundt <[email protected]>
Signed-off-by: Erik Kundt <[email protected]>
Signed-off-by: Erik Kundt <[email protected]>
Signed-off-by: Erik Kundt <[email protected]>
Signed-off-by: Erik Kundt <[email protected]>
Signed-off-by: Erik Kundt <[email protected]>
Signed-off-by: Erik Kundt <[email protected]>
Signed-off-by: Erik Kundt <[email protected]>
Signed-off-by: Erik Kundt <[email protected]>
Signed-off-by: Erik Kundt <[email protected]>
erak
force-pushed
the
erak/issues-tui-realm
branch
from
58b3735
to
d2d9582
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo
rad-issue-tui.mp4
Description
Requires #171