seed: consider if tracking relationship was already established #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kim
force-pushed
the
kim/seed-check-already-tracked
branch
from
f937165 to
3c76aef
Compare
kim
commented
Aug 19, 2021
|
Please pull out your truth tables and verify I got the booleans right |
When calling `Node::track_project`, it might very well be that the project/peer is already tracked, which would result in unnecessary broadcast traffic. Thus, don't emit any events in this case. Also, change the order of `track` and `replicate` to ensure we do actually fetch the newly-tracked peer's view. Additionally, we can skip `replicate` if we already tracked the peer, as subsequent broadcast messages won't be considered uninteresting. Ref #734 Signed-off-by: Kim Altintop <[email protected]>
kim
force-pushed
the
kim/seed-check-already-tracked
branch
from
d5f4db8 to
4996751
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
Node::track_project, it might very well be that theproject/peer is already tracked, which would result in unnecessary
broadcast traffic. Thus, don't emit any events in this case.
Also, change the order of
trackandreplicateto ensure wedo actually fetch the newly-tracked peer's view. Additionally, we can
skip
replicateif we already tracked the peer, as subsequent broadcastmessages won't be considered uninteresting.
Ref #734
Signed-off-by: Kim Altintop [email protected]