[DismissableLayer] Fix race condition between layers closing at the same time #3425
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I encountered a bug where multiple layers closing at the same time would both determine that
context.layersWithOutsidePointerEventsDisabled.size > 1
which prevented the pointer events from being reset back to it's original value. By moving thecontext.layersWithOutsidePointerEventsDisabled.delete(node)
to inside of the clean up method for the outer events hook, the race condition is resolved.I see the comment about "We purposefully prevent combining this effect with the
disableOutsidePointerEvents
effect" which this PR might not be aligned with. My thought is that the context.layers could represent the "creation order" while context.layersWithOutsidePointerEventsDisabled would not need to adhere to that.