Enable ROCK 5B early PD negotiation #22
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2d3bbca. Signed-off-by: ZHANG Yuntian <[email protected]>
This reverts commit 8584db7. Signed-off-by: ZHANG Yuntian <[email protected]>
Signed-off-by: ZHANG Yuntian <[email protected]>
Signed-off-by: ZHANG Yuntian <[email protected]>
This prevents PD adapter timeout on negotiation, so Linux could renegotiate it later. Signed-off-by: ZHANG Yuntian <[email protected]>
Signed-off-by: ZHANG Yuntian <[email protected]>
With some adapters, when the device is rebooted, the data role will mismatch since Linux changed the data role. However, the default ERROR_RECOVERY sequence will prevent the device from booting again. Hard resetting seems to work better on those adapters. Call tcpm_pd_hard_reset instead, which will fall back to ERROR_RECOVERY when hard reset itself fails. Signed-off-by: ZHANG Yuntian <[email protected]>
Signed-off-by: ZHANG Yuntian <[email protected]>
Signed-off-by: ZHANG Yuntian <[email protected]>
|
This will break dp altmode when kernel starts negotiation because u-boot has negotiated with PD_REV20, and kernel will not send |
|
Yes this is what I observed as well. Were you able to negotiated PD_REV30 under U-Boot? |
|
I haven't get PD_REV30 either, need to investigate the tcpm driver code in uboot. |
|
Dp alt mode would work under PD_REV20. But when uboot has negotiated, kernel will not light up my typec monitor. I think it is because of the lacking of drp/ufp detection and dp alt mode support in the uboot driver. If I don't do negotiation in uboot, kernel will light up my typec monitor by PD_REV20. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-enables the PD related settings for ROCK 5B, and add early negotiation via
CONFIG_PREBOOT. As a bonus, U-Boot console is re-enabled as well.