Add AAC as supported audio format #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a collection of sounds I really like and I downloaded them through
yt-dlpwhich is usually encoded in aac and opus.yt-dlpusually outputs aac into .m4a container which can hold either aac or alac. I tested an .m4a with alac and it didn't play, so I stuck with using .aac file format, which has its own mime type. Ffmpeg lets youffmpeg -i in.m4a -c:a copy out.aacThis change makes it a lot easier to import from
yt-dlpwithout re-encoding. It's better to leave the codec the way it is to reduce data loss or unnecessarily increase file size.Let me know if you want me to test opus or consider adding m4a. Thank you so much for the cute cozy program. Blanket is really really nice! It helps me feel so grounded and comfy cause it's GTK 4.