Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow watchSticker to watch more than one target #3

Closed
wants to merge 2 commits into from
Closed

Allow watchSticker to watch more than one target #3

wants to merge 2 commits into from

Conversation

murtinha
Copy link

Closes #1

rafaelverger
rafaelverger requested changes Jan 10, 2018
View reviewed changes
Copy link
Owner

@rafaelverger rafaelverger left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[edited]

rafaelverger
rafaelverger requested changes Jan 10, 2018
View reviewed changes
Copy link
Owner

@rafaelverger rafaelverger left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check my comment and try to add some tests that guarantees sticker.watchStickerTimeout is cleaned on SOS.watchSticker(evt, sticker)

index.js
@@ -66,7 +68,7 @@ const SOS = {
/* eslint-disable no-param-reassign */
sticker.stick = (e) => {
if (!this.watchStickerTimeout) {
this.watchStickerTimeout = window.setTimeout(() => {
sticker.watchStickerTimeout = window.setTimeout(() => {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

u've forgot to change this.watchStickerTimeout from the line 70.

@murtinha murtinha closed this Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaelverger rafaelverger rafaelverger requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@murtinha @rafaelverger