Always wrap variables in ModifiedDiskArray even when it does nothing
#892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@felixcremer the zarr test file on bgi jena doesn't seem to exist anymore. Do you have a more reliable long term test file? Or can we put one somewhere? I've commented out the zarr tests for now but thats less than ideal, especially would be good to test these changes with zarr too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We unfortunately can't rely on CommonDataModel.jl packages to implement the DiskArrays.jl interface properly, e.g. #889
But they at least have
eachchunk/haschunks/readblock!etc.So as a general strategy we will wrap them in a properly implemented disk array and prevent them from ever being exposed to dispatch methods other than
readblock!etc.