Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not create a new transaction when creating a ReadyExecution #424

Closed
wants to merge 2 commits into from
Closed

Do not create a new transaction when creating a ReadyExecution #424

wants to merge 2 commits into from

Conversation

leondmello
Copy link

Fixes #421

@leondmello
Copy link
Author

@rosa Does this line need the same change?

solid_queue/app/models/solid_queue/job/schedulable.rb

Line 40 in 393e3b9

ScheduledExecution.create_or_find_by!(job_id: id)

@rosa
Copy link
Member

rosa commented Nov 22, 2024

Closing per #421 (comment).

@rosa rosa closed this Nov 22, 2024
@leondmello leondmello deleted the patch-1 branch November 22, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@leondmello @rosa