reorg ens related calls (#5828)

rainbow-me · Jun 7, 2024 · ca22bfd · ca22bfd
1 parent 6642231
commit ca22bfd
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 22 deletions.
diff --git a/src/components/cards/ENSCreateProfileCard.tsx b/src/components/cards/ENSCreateProfileCard.tsx
@@ -1,4 +1,4 @@
-import React, { useEffect } from 'react';
+import React, { useCallback, useEffect } from 'react';
 import ENSAvatarGrid from '../../assets/ensAvatarGrid.png';
 import ENSIcon from '../../assets/ensIcon.png';
 import { useNavigation } from '../../navigation/Navigation';
@@ -33,8 +33,15 @@ export const ENSCreateProfileCard = () => {
   // 40 represents the horizontal padding outside the card
   const imageWidth = deviceWidth - 40;
 
-  const handlePress = () => {
+  const { uniqueDomain } = useAccountENSDomains();
+
+  const handlePress = useCallback(() => {
     if (!isReadOnlyWallet || enableActionsOnReadOnlyWallet) {
+      if (uniqueDomain?.name) {
+        prefetchENSAvatar(uniqueDomain.name);
+        prefetchENSRecords(uniqueDomain.name);
+      }
+
       analyticsV2.track(analyticsV2.event.cardPressed, {
         cardName: 'ENSCreateProfileCard',
         routeName,
@@ -46,16 +53,7 @@ export const ENSCreateProfileCard = () => {
     } else {
       watchingAlert();
     }
-  };
-
-  const { uniqueDomain } = useAccountENSDomains();
-
-  useEffect(() => {
-    if (uniqueDomain?.name) {
-      prefetchENSAvatar(uniqueDomain.name);
-      prefetchENSRecords(uniqueDomain.name);
-    }
-  }, [uniqueDomain]);
+  }, [isReadOnlyWallet, navigate, routeName, uniqueDomain?.name]);
 
   return (
     <ColorModeProvider value="lightTinted">

diff --git a/src/hooks/useOnAvatarPress.ts b/src/hooks/useOnAvatarPress.ts
@@ -54,14 +54,6 @@ export default ({ screenType = 'transaction' }: UseOnAvatarPressProps = {}) => {
   const { startRegistration } = useENSRegistration();
   const { setNextEmoji } = useUpdateEmoji();
 
-  useEffect(() => {
-    if (accountENS) {
-      prefetchENSAvatar(accountENS);
-      prefetchENSCover(accountENS);
-      prefetchENSRecords(accountENS);
-    }
-  }, [accountENS]);
-
   const onAvatarRemovePhoto = useCallback(async () => {
     const newWallets: typeof wallets = {
       ...wallets,
@@ -256,6 +248,12 @@ export default ({ screenType = 'transaction' }: UseOnAvatarPressProps = {}) => {
   }, [accountENS, navigate]);
 
   const onAvatarPress = useCallback(() => {
+    if (accountENS) {
+      prefetchENSAvatar(accountENS);
+      prefetchENSCover(accountENS);
+      prefetchENSRecords(accountENS);
+    }
+
     if (hasENSAvatar && accountENS) {
       onAvatarPressProfile();
     } else {

diff --git a/src/redux/wallets.ts b/src/redux/wallets.ts
@@ -207,8 +207,6 @@ export const walletsLoadState =
         type: WALLETS_LOAD,
       });
 
-      dispatch(fetchWalletNames());
-      profilesEnabled && dispatch(fetchWalletENSAvatars());
       return wallets;
     } catch (error) {
       logger.error(new RainbowError('Exception during walletsLoadState'), {