Remove non-Favorites lists #5084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APP-819 Remove UI components + tear out obsolete logic
|
|
don't panic, the redux state usage that was added will be removed shortly |
|
Can you also remove any relevant test for lists in e2e/discoverSheetFlow.spec.js |
skylarbarrera
approved these changes
Oct 10, 2023
| @@ -305,7 +303,7 @@ const ExchangeAssetList: ForwardRefRenderFunction< | |||
| setLocalFavorite(prev => { | |||
| const address = rowData.address; | |||
| const newValue = !prev?.[address]; | |||
| updateList(address, 'favorites', newValue); | |||
| dispatch(uniswapUpdateFavorites(address, newValue)); | |||
There was a problem hiding this comment.
this is gonna have conflicts post other PR yeah?
* temp * stuff * rm sandbox * finished * rm extra line * rm obsolete code * rm e2e * Remove uniswap pairs redux (#5093) * move uniswap pairs from redux to react query * rm uniswap pairs redux * rm testnets util * react query + migration * more react query * rm logs * rm resources/favorites * rm comment * Remove favorites redux (#5104) * tearing everything out * fix favorites not persisting bug * docs * typo
…@benisgold/lists3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-819
What changed (plus any additional context for devs)
In this PR:
Remove UI + logic for non-favorites lists (trending, watchlist, defi, stablecoins)
In the followup PRs:
Minor UI updates, refactor of remaining logic
Specifics:
Listscomponent fromDiscoverHomeAddTokenSheetuserListsredux touniswapredux. The favorites list's existence/handling inuserListsredux is just a wrapper arounduniswapredux.userListsreduxuseUserListshookScreen recordings / screenshots
Simulator.Screen.Recording.-.iPhone.14.-.2023-09-28.at.13.22.14.mp4
What to test