Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OP Round 2 Rewards Sheet #5110

Merged
merged 20 commits into from
Oct 12, 2023
Merged

Update OP Round 2 Rewards Sheet #5110

merged 20 commits into from
Oct 12, 2023

Conversation

walmat
Copy link
Contributor

@walmat walmat commented Oct 10, 2023

Fixes RNBW-4698

What changed (plus any additional context for devs)

Adjusted OP Rewards sheet to match Round 2 designs/spec.

Screen recordings / screenshots

Screenshot 2023-10-10 at 4 27 17 PM Screenshot 2023-10-10 at 4 26 55 PM

What to test

  1. Enable $OP Rewards feature flag in settings
  2. Verify that the card is featured underneath NFTs/Mints in the discover page
  3. Click on the card and verify the Rewards sheet shows
  4. Report any css/alignment issues if found

@linear
Copy link

linear bot commented Oct 10, 2023

RNBW-4698 Rewards Sheet

Create rewards details sheet. Entry point should be discover card.

Note: component immediately below title should be as reusable as possible. Christian mentioned that it will be used again in an upcoming feature.

ios/Rainbow.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
src/components/sheet/DynamicHeightSheet.js Outdated Show resolved Hide resolved
src/components/info-alert/info-alert.tsx Outdated Show resolved Hide resolved
src/components/info-alert/info-alert.tsx Outdated Show resolved Hide resolved
src/components/info-alert/info-alert.tsx Outdated Show resolved Hide resolved
src/components/info-alert/info-alert.tsx Outdated Show resolved Hide resolved
src/screens/rewards/components/RewardsSectionCard.tsx Outdated Show resolved Hide resolved
src/screens/rewards/components/RewardsStats.tsx Outdated Show resolved Hide resolved
src/screens/rewards/components/RewardsStatsCard.tsx Outdated Show resolved Hide resolved
src/styles/colors.ts Outdated Show resolved Hide resolved
@walmat walmat changed the title @matthew/rnbw 4698 Update OP Round 2 Rewards Sheet Oct 11, 2023
@walmat
Copy link
Contributor Author

walmat commented Oct 11, 2023

Updated screenshots:
Screenshot 2023-10-11 at 3 04 21 PM
Screenshot 2023-10-11 at 3 03 52 PM
Screenshot 2023-10-11 at 3 04 17 PM
Screenshot 2023-10-11 at 3 03 57 PM

Copy link
Contributor

@skylarbarrera skylarbarrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful stuff

@jinchung jinchung merged commit 7adda76 into develop Oct 12, 2023
4 of 5 checks passed
@jinchung jinchung deleted the @matthew/RNBW-4698 branch October 12, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants