Fix refresh persistence bug

[jinchung]

Fixes APP-840

[walmat]

LGTM! Nice work. Pull to refresh working. Not necessarily related to the changes made through this PR, but should the refetchInterval be lowered? 5 minutes seems like a long time to keep price data unless manually refreshed.

[linear]

APP-840 Balance updates don't consistently persist app sessions

https://rainbowhaus.slack.com/archives/C02C2FVC6N6/p1696214226512439

Broadly, issue was keeping async storage as well as react-query's path to async storage, which is separate.

We would update the data in dataLoadState in the redux/data file from the old async storage instead of reading from the new async storage.

You'll noticed I also removed some other part of the code that was updating asset information (and also updating the old redux state) which we had put in place before our backend data was as robust as it is now.

On simulator, I have confirmed refreshing data, killing the app and coming back, on both empty and non-empty wallets.

[jinchung]

LGTM! Nice work. Pull to refresh working. Not necessarily related to the changes made through this PR, but should the refetchInterval be lowered? 5 minutes seems like a long time to keep price data unless manually refreshed.

Thanks! I'll take a revisit to this separately - will depend on caching timeouts on the backend and also would like to be thoughtful bc this is the "assets balances" endpoint and we still have the separate websockets endpoint for generic asset prices, which I would need to check if we're subscribing to anyway for the wallet's assets as well

[skylarbarrera]

agree 5 min seems way too long

[ibrahimtaveras00]

Looks good on both OS's 👍🏽