Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enabled tests in deeplinks and sendSheetFlow #5161

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Re-enabled tests in deeplinks and sendSheetFlow #5161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions e2e/deeplinks.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,19 +109,19 @@ describe('Deeplinks spec', () => {
await Helpers.swipe('profile-sheet', 'down');
});

it.skip('should be able to handle ethereum payments urls for ETH (mainnet)', async () => {
it('should be able to handle ethereum payments urls for ETH (mainnet)', async () => {
const url = escapeUrl('ethereum:payment-brunobarbieri.eth@1?value=1e2');
await testEthereumDeeplink(url, false);
});

it.skip('should be able to handle ethereum payments urls for ETH (optimism)', async () => {
it('should be able to handle ethereum payments urls for ETH (optimism)', async () => {
const url = escapeUrl('ethereum:payment-brunobarbieri.eth@10?value=1e15');
await testEthereumDeeplink(url, false);
});

// FIXME: when doing open deeplinks with cold start, the account assets state
// comes back empty, find a fix and then change these tests to cold-start again
it.skip('should be able to handle ethereum payments urls for DAI (mainnet)', async () => {
it('should be able to handle ethereum payments urls for DAI (mainnet)', async () => {
const url = escapeUrl(
'ethereum:0x6b175474e89094c44da98b954eedeac495271d0f@1/transfer?address=brunobarbieri.eth&uint256=1e18'
);
Expand All @@ -130,14 +130,14 @@ describe('Deeplinks spec', () => {

// FIXME: when doing open deeplinks with cold start, the account assets state
// comes back empty, find a fix and then change these tests to cold-start again
it.skip('should be able to handle ethereum payments urls for ETH (arbitrum)', async () => {
it('should be able to handle ethereum payments urls for ETH (arbitrum)', async () => {
const url = 'ethereum:payment-brunobarbieri.eth@42161?value=1e15';
await testEthereumDeeplink(url, false);
});

// FIXME: when doing open deeplinks with cold start, the account assets state
// comes back empty, find a fix and then change these tests to cold-start again
it.skip('should be able to handle ethereum payments urls for DAI (optimism)', async () => {
it('should be able to handle ethereum payments urls for DAI (optimism)', async () => {
const url = escapeUrl(
'ethereum:0xda10009cbd5d07dd0cecc66161fc93d7c9000da1@10/transfer?address=brunobarbieri.eth&uint256=1e15'
);
Expand All @@ -146,7 +146,7 @@ describe('Deeplinks spec', () => {

// FIXME: when doing open deeplinks with cold start, the account assets state
// comes back empty, find a fix and then change these tests to cold-start again
it.skip('should be able to handle ethereum payments urls for MATIC (polygon)', async () => {
it('should be able to handle ethereum payments urls for MATIC (polygon)', async () => {
const url = escapeUrl('ethereum:payment-brunobarbieri.eth@137?value=1e15');
await testEthereumDeeplink(url, false);
});
Expand Down
21 changes: 10 additions & 11 deletions e2e/sendSheetFlow.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,19 +100,18 @@ describe('Send Sheet Interaction Flow', () => {
// populate
//
// SKIPPING all tests after this one, as the app is in the wrong state
it.skip('Should show show Contact Button & Asset List on valid public address', async () => {
it('Should show show Contact Button & Asset List on valid public address', async () => {
await Helpers.clearField('send-asset-form-field');
await Helpers.checkIfVisible('send-asset-form-field');
await Helpers.typeText(
await Helpers.replaceTextInField(
'send-asset-form-field',
'0xF0f21ab2012731542731df194cfF6c77d29cB31A',
false
'0xF0f21ab2012731542731df194cfF6c77d29cB31A'
);
// await Helpers.checkIfVisible('add-contact-button');
await Helpers.checkIfVisible('send-asset-list', 20000);
});

it.skip('Should show show Contact Button & Asset List on valid ENS & Unstoppable addresses', async () => {
it('Should show show Contact Button & Asset List on valid ENS & Unstoppable addresses', async () => {
await Helpers.clearField('send-asset-form-field');
await Helpers.checkIfVisible('send-asset-form-field');
await Helpers.typeText(
Expand Down Expand Up @@ -193,32 +192,32 @@ describe('Send Sheet Interaction Flow', () => {
await Helpers.waitAndTap('send-asset-form-ETH-token');
});

it.skip('Should display Asset Form after tapping on asset ETH', async () => {
it('Should display Asset Form after tapping on asset ETH', async () => {
await Helpers.checkIfVisible('send-asset-ETH-token');
await Helpers.waitAndTap('send-asset-ETH-token');
await Helpers.checkIfVisible('selected-asset-field-input');
});

it.skip('Should display max button on asset input focus ETH', async () => {
it('Should display max button on asset input focus ETH', async () => {
await Helpers.checkIfVisible('selected-asset-field-input');
await Helpers.waitAndTap('selected-asset-field-input');
await Helpers.checkIfElementByTextIsVisible('Max');
});

it.skip('Should display max button on asset quantity input focus ETH', async () => {
it('Should display max button on asset quantity input focus ETH', async () => {
await Helpers.checkIfVisible('selected-asset-quantity-field-input');
await Helpers.waitAndTap('selected-asset-quantity-field-input');
await Helpers.checkIfElementByTextIsVisible('Max');
});

it.skip('Should display Insufficient Funds button if exceeds asset balance ETH', async () => {
it('Should display Insufficient Funds button if exceeds asset balance ETH', async () => {
await Helpers.checkIfVisible('selected-asset-field-input');
await Helpers.waitAndTap('selected-asset-field-input');
await Helpers.typeText('selected-asset-field-input', '9999', true);
await Helpers.checkIfElementByTextIsVisible('Insufficient Funds');
});

it.skip('Should prepend a 0 to quantity field on input of . ETH', async () => {
it('Should prepend a 0 to quantity field on input of . ETH', async () => {
await Helpers.waitAndTap('send-asset-form-ETH-token');
await Helpers.waitAndTap('send-asset-ETH-token');
await Helpers.checkIfVisible('selected-asset-quantity-field-input');
Expand All @@ -227,7 +226,7 @@ describe('Send Sheet Interaction Flow', () => {
await Helpers.checkIfElementByTextIsVisible('0.');
});

it.skip('Should only show a max of 2 decimals in quantity field ETH', async () => {
it('Should only show a max of 2 decimals in quantity field ETH', async () => {
await Helpers.waitAndTap('send-asset-form-ETH-token');
await Helpers.waitAndTap('send-asset-ETH-token');
await Helpers.checkIfVisible('selected-asset-quantity-field-input');
Expand Down