-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update notifications subscription #5189
Closed
jinchung
wants to merge
27
commits into
@jin/notifs-sub-network-settings
from
@jin/notifications-sub-update
Closed
Update notifications subscription #5189
jinchung
wants to merge
27
commits into
@jin/notifs-sub-network-settings
from
@jin/notifications-sub-update
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinchung
force-pushed
the
@jin/notifications-sub-update
branch
from
November 17, 2023 17:21
cc1bfd0
to
39e708c
Compare
jinchung
force-pushed
the
@jin/notifications-sub-update
branch
5 times, most recently
from
November 29, 2023 16:59
5c0e4d2
to
62aa04d
Compare
initialization Previously, we had to do firebase subscriptions one at a time. With the new API, we need to provide the full state of enabled notifications.
…sting wallet settings
…s back to generic message less
… settings for a wallet
jinchung
force-pushed
the
@jin/notifications-sub-update
branch
from
November 29, 2023 17:23
62aa04d
to
e6b33a4
Compare
jinchung
changed the base branch from
develop
to
@jin/notifs-sub-network-settings
November 29, 2023 17:23
jinchung
force-pushed
the
@jin/notifications-sub-update
branch
from
November 29, 2023 17:29
e6b33a4
to
4fbc3ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.