Notification subscription endpoints (pt2) #5208
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinchung
changed the base branch from
develop
to
@jin/notifs-sub-network-settings
jinchung
force-pushed
the
@jin/notif-new-sub-endpoint
branch
9 times, most recently
from
cbd8978 to
2d7be88
Compare
jinchung
commented
Nov 29, 2023
| @@ -59,6 +59,7 @@ declare module 'react-native-dotenv' { | |||
| export const CLOUDINARY_API_KEY: string; | |||
| export const CLOUDINARY_API_SECRET: string; | |||
| export const CLOUDINARY_CLOUD_NAME: string; | |||
| export const NOTIFICATIONS_API_KEY: string; | |||
There was a problem hiding this comment.
This was merged in rainbow env here: https://github.com/rainbow-me/rainbow-env/pull/52
jinchung
commented
Nov 30, 2023
| @@ -91,6 +91,7 @@ function generateError({ | |||
| }) { | |||
| const message = | |||
| responseBody?.error || | |||
| responseBody?.message || | |||
There was a problem hiding this comment.
we often use "message" in our RainbowErrors and without this, it was often falling back to the generic "There was an error with the request"
jinchung
force-pushed
the
@jin/notifs-sub-network-settings
branch
from
93ebbc4 to
c85f7df
Compare
jinchung
force-pushed
the
@jin/notif-new-sub-endpoint
branch
from
59c2407 to
3cdf46c
Compare
jinchung
force-pushed
the
@jin/notifs-sub-network-settings
branch
from
c85f7df to
5813d7b
Compare
Includes retries if the current FCM token is out of date.
…s back to generic message less
jinchung
force-pushed
the
@jin/notif-new-sub-endpoint
branch
from
3cdf46c to
8d1adb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-887
This PR is a noop.
This adds (currently unused) functionality for subscribing to notifications and saving the new notifications settings.