Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Points: format large numbers in rank card #5265

Merged
merged 4 commits into from
Dec 14, 2023
Merged

Points: format large numbers in rank card #5265

merged 4 commits into from
Dec 14, 2023

Conversation

benisgold
Copy link
Contributor

Fixes APP-1017

What changed (plus any additional context for devs)

  • change "out of" to "of"
  • if small phone, don't show icon if 8 fig total users
  • for user rank:
    • if 8 figs, size = "17pt"
    • if 7 figs, size = "20pt"
    • else, size = "22pt"

Screen recordings / screenshots

Simulator Screenshot - iPhone 14 Pro - 2023-12-14 at 10 37 47
Simulator Screenshot - iPhone 14 Pro - 2023-12-14 at 10 38 33
Simulator Screenshot - iPhone 14 Pro - 2023-12-14 at 10 39 05
Simulator Screenshot - iPhone SE (3rd generation) - 2023-12-14 at 11 03 57
Simulator Screenshot - iPhone SE (3rd generation) - 2023-12-14 at 11 04 15

What to test

@linear Linear
Copy link

linear bot commented Dec 14, 2023

APP-1017 Accommodate large rank / large num users in rank card

dereknelson
dereknelson approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@dereknelson dereknelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

points points points

@jinchung jinchung merged commit defdb3c into develop Dec 14, 2023
5 of 6 checks passed
@jinchung jinchung deleted the @benisgold/points-large-nums branch December 14, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dereknelson dereknelson dereknelson approved these changes

@walmat walmat walmat approved these changes

@jinchung jinchung Awaiting requested review from jinchung

@skylarbarrera skylarbarrera Awaiting requested review from skylarbarrera

Assignees
No one assigned
Labels
rainbow points
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benisgold @walmat @dereknelson @jinchung