Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APP-1012]: fix logger.error not being given a `RainbowError instance #5269

Closed
wants to merge 1 commit into from
Closed

[APP-1012]: fix logger.error not being given a `RainbowError instance #5269

wants to merge 1 commit into from

Conversation

walmat
Copy link
Contributor

@walmat walmat commented Dec 14, 2023

Fixes APP-1012

What changed (plus any additional context for devs)

Screen recordings / screenshots

What to test

@linear Linear
Copy link

linear bot commented Dec 14, 2023

APP-1012 Error: logger.error was not provided a RainbowError

benisgold
benisgold approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@benisgold benisgold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

he can't be stopped

@walmat walmat added the release for release blockers and release candidate branches label Dec 14, 2023
@walmat walmat closed this Dec 15, 2023
@walmat walmat deleted the @matthew/APP-1012 branch March 18, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skylarbarrera skylarbarrera skylarbarrera left review comments

@benisgold benisgold benisgold approved these changes

Assignees
No one assigned
Labels
release for release blockers and release candidate branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@walmat @benisgold @skylarbarrera