Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Points: UI for "unranked" users #5293

Merged
merged 6 commits into from
Dec 19, 2023
Merged

Points: UI for "unranked" users #5293

merged 6 commits into from
Dec 19, 2023

Conversation

benisgold
Copy link
Contributor

@benisgold benisgold commented Dec 19, 2023 •
edited
Loading

Fixes APP-1031

What changed (plus any additional context for devs)

  • display that user is "unranked" if points < 750. unranked is a property provided by backend so app doesn't actually check the user's point count.
  • see figma here
Screenshot 2023-12-19 at 10 31 49 AM

Screen recordings / screenshots

Simulator Screenshot - iPhone 14 Pro - 2023-12-19 at 10 31 11
Simulator Screenshot - iPhone SE (3rd generation) - 2023-12-19 at 10 30 58

What to test

@linear Linear
Copy link

linear bot commented Dec 19, 2023

APP-1031 Unranked state

@benisgold benisgold added release for release blockers and release candidate branches rainbow points labels Dec 19, 2023
@benisgold benisgold marked this pull request as ready for review December 19, 2023 18:33
@benisgold benisgold changed the title @benisgold/points unranked Points: UI for "Unranked" users Dec 19, 2023
@benisgold benisgold changed the title Points: UI for "Unranked" users Points: UI for "unranked" users Dec 19, 2023
walmat
walmat approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@walmat walmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested Android ✅

@nickbytes nickbytes merged commit dc6a91c into develop Dec 19, 2023
5 of 6 checks passed
@nickbytes nickbytes deleted the @benisgold/points-unranked branch December 19, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walmat walmat walmat approved these changes

@dereknelson dereknelson Awaiting requested review from dereknelson

@skylarbarrera skylarbarrera Awaiting requested review from skylarbarrera

Assignees
No one assigned
Labels
rainbow points release for release blockers and release candidate branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benisgold @walmat @nickbytes