Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swaps v2 gas #5526

Merged
merged 27 commits into from
Apr 3, 2024
Merged

swaps v2 gas #5526

merged 27 commits into from
Apr 3, 2024

Conversation

dereknelson
Copy link
Contributor

@dereknelson dereknelson commented Mar 18, 2024 •
edited
Loading

Fixes APP-1229

What changed (plus any additional context for devs)

mostly utils & types

Screen recordings / screenshots

image

What to test

@linear Linear
Copy link

linear bot commented Mar 18, 2024

APP-1229 Implement gas estimations

@dereknelson dereknelson requested a review from walmat March 18, 2024 16:21
@dereknelson dereknelson marked this pull request as ready for review March 20, 2024 19:13
@dereknelson dereknelson requested a review from jinchung as a code owner March 28, 2024 15:33
@socket-security Socket Security
Copy link

socket-security bot commented Mar 28, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@ledgerhq/[email protected] None 0 190 kB ldg-github-ci
npm/@ledgerhq/[email protected] None +1 331 kB ldg-github-ci
npm/@metamask/[email protected] None +5 832 kB metamaskbot
npm/@noble/[email protected] None 0 773 kB paulmillr
npm/@scure/[email protected] None 0 80.4 kB paulmillr
npm/[email protected] None +1 35.5 kB ljharb
npm/[email protected] None +37 3.1 MB ljharb
npm/[email protected] environment, filesystem, network +10 591 kB wesleytodd
npm/[email protected] None +1 40.2 kB ljharb
npm/[email protected] network 0 735 kB pi0
npm/[email protected] None +1 40.7 kB ljharb
npm/[email protected] None 0 103 kB pi0
npm/[email protected] None +4 92.7 kB ljharb

🚮 Removed packages: npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/plugin-bugfix-safari-id-destructuring-collision-in-function-expression@7.23.3, npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@metamask/[email protected], npm/@scure/[email protected], npm/@webassemblyjs/[email protected], npm/@webassemblyjs/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

skylarbarrera
skylarbarrera suggested changes Apr 2, 2024
View reviewed changes
src/__swaps__/references/index.ts Outdated Show resolved Hide resolved
src/__swaps__/screens/Swap/components/GasButton.tsx Show resolved Hide resolved
src/__swaps__/screens/Swap/components/GasButton.tsx Outdated Show resolved Hide resolved
src/__swaps__/screens/Swap/components/GasButton.tsx Outdated Show resolved Hide resolved
src/__swaps__/screens/Swap/components/GasButton.tsx Outdated Show resolved Hide resolved
src/__swaps__/screens/Swap/components/GasButton.tsx Outdated Show resolved Hide resolved
src/__swaps__/utils/gasUtils.ts Outdated Show resolved Hide resolved
src/__swaps__/utils/time.ts Show resolved Hide resolved
src/state/gas/gasStore.ts Outdated Show resolved Hide resolved
src/state/gas/gasStore.ts Outdated Show resolved Hide resolved
skylarbarrera
skylarbarrera reviewed Apr 3, 2024
View reviewed changes
Copy link
Contributor

@skylarbarrera skylarbarrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shore

@skylarbarrera skylarbarrera self-requested a review April 3, 2024 21:29
@dereknelson
Copy link
Contributor Author

@skylarbarrera admin merge king??

@skylarbarrera skylarbarrera merged commit e148fa5 into develop Apr 3, 2024
5 of 6 checks passed
@skylarbarrera skylarbarrera deleted the @derek/gasv2 branch April 3, 2024 22:20
BrodyHughes added a commit that referenced this pull request Apr 10, 2024
@BrodyHughes
Merge branch 'develop' of github.com:rainbow-me/rainbow into brody/e2…
76addf0 
…e-changes

* 'develop' of github.com:rainbow-me/rainbow: (44 commits)
  allow open in new tab (#5610)
  added warning for unknown price impact (#5597)
  fix cloudflare protection (#5609)
  improve type checking on web preferences (#5607)
  fix scrolltoindex firing on last card dismissal (#5606)
  make account network switcher work (#5604)
  Dapp browser fixes (#5596)
  Fix close tab btn (#5598)
  browser: add account context menu (#5603)
  Fix instant screenshot setting (#5602)
  swaps: bump sdk (#5583)
  Browser: tab transitions, state update queue (#5582)
  audit: undici (#5594)
  [SWAPS V2]: Add token search logic and ability to select assets (#5547)
  swaps v2 gas (#5526)
  tx sim: other natives (#5585)
  Brody/bump 1.9.21 3 (#5588)
  fix sheet bg (#5590)
  Only hold the active tab ref in BrowserContext (#5579)
  Dapp browser: disable tab closing for empty state (#5573)
  ...
BrodyHughes added a commit that referenced this pull request Apr 10, 2024
@BrodyHughes
Merge branch 'develop' of github.com:rainbow-me/rainbow into develop
2a839e5 
* 'develop' of github.com:rainbow-me/rainbow:
  make account network switcher work (#5604)
  Dapp browser fixes (#5596)
  Fix close tab btn (#5598)
  browser: add account context menu (#5603)
  Fix instant screenshot setting (#5602)
  swaps: bump sdk (#5583)
  Browser: tab transitions, state update queue (#5582)
  audit: undici (#5594)
  [SWAPS V2]: Add token search logic and ability to select assets (#5547)
  swaps v2 gas (#5526)
  tx sim: other natives (#5585)
  Brody/bump 1.9.21 3 (#5588)
  fix sheet bg (#5590)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skylarbarrera skylarbarrera skylarbarrera approved these changes

@benisgold benisgold Awaiting requested review from benisgold

@jinchung jinchung Awaiting requested review from jinchung

@walmat walmat Awaiting requested review from walmat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dereknelson @walmat @skylarbarrera