added warning for unknown price impact #5597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dereknelson just to be clear on requirements being met here:
Is that correct? |
|
@nickbytes yeah, in all the cases i tried it seems like the impact defaults to 100% when we don't know it, and is only NaN when it's loading |
|
@skylarbarrera i'll merge after i add warning to review sheet |
BrodyHughes
added a commit
that referenced
this pull request
Apr 10, 2024
…e-changes * 'develop' of github.com:rainbow-me/rainbow: (44 commits) allow open in new tab (#5610) added warning for unknown price impact (#5597) fix cloudflare protection (#5609) improve type checking on web preferences (#5607) fix scrolltoindex firing on last card dismissal (#5606) make account network switcher work (#5604) Dapp browser fixes (#5596) Fix close tab btn (#5598) browser: add account context menu (#5603) Fix instant screenshot setting (#5602) swaps: bump sdk (#5583) Browser: tab transitions, state update queue (#5582) audit: undici (#5594) [SWAPS V2]: Add token search logic and ability to select assets (#5547) swaps v2 gas (#5526) tx sim: other natives (#5585) Brody/bump 1.9.21 3 (#5588) fix sheet bg (#5590) Only hold the active tab ref in BrowserContext (#5579) Dapp browser: disable tab closing for empty state (#5573) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-1295
What changed (plus any additional context for devs)
it appears that when we have no pricing data, the price impact always severe at 100%
if we haven't gotten the price impact response yet, it's NaN
Screen recordings / screenshots
pending final copy from @christianbaroniWhat to test
that this message is not shown when we do have price impact data