-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]: Swaps v2 quote fetching #5601
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
f1dbf98
impl basic quote fetching logic
walmat 3ee8422
quote fetching sort of working
walmat ee55f8e
update to quote fetching for slider functionality
walmat a1b37ae
fixes
walmat 24af2e5
more progress on quote fetching
walmat 8f52799
bump swaps sdk and improvements to flip button and quote fetching
walmat d4ecc75
stash: niceIncrement is causing NaN on slider change
walmat 436aef7
chore: merge develop
walmat 0ad7093
more cleanup and fixed NaN slider issue
walmat c3e3011
progress on asset swapping
walmat 86f21b6
fix race condition happening when swapping assets
walmat 9b7f9cb
Merge branch 'develop' into @matthew/swaps-quote-fetching
walmat fa3f1fe
another NaN edge cases
walmat 03edc49
update some price fetching logic
walmat 12c4b60
todo comments
walmat 045a3f8
add formatting to asset rates
walmat ec03f5f
Merge branch 'develop' into @matthew/swaps-quote-fetching
walmat 77f8ae9
update to favorite tokens list and left some todos
walmat e4a3a07
fix lint
walmat cd328cb
cleanup redundancy between DEFAULT_SLIPPAGE
walmat bcfbd41
fix some runtime errors
walmat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we shouldnt be using toLocaleString since it doenst play with with the rest of the supported currencies, we have a JS util might just need to write it as a worklet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a new ticket: https://linear.app/rainbow/issue/APP-1346/switch-tolocalestring-to-support-other-nativecurrencies