Swaps: Input List #5728
Closed
Swaps: Input List #5728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walmat
reviewed
May 15, 2024
walmat
reviewed
May 15, 2024
walmat
reviewed
May 15, 2024
walmat
reviewed
May 17, 2024
Comment on lines
32
to
35
| const nameMatch = asset.name.toLowerCase().includes(searchQuery); | ||
| const symbolMatch = asset.symbol.toLowerCase().startsWith(searchQuery); | ||
| const addressMatch = asset.address.toLowerCase().startsWith(searchQuery); | ||
| if (nameMatch || symbolMatch || addressMatch) { |
There was a problem hiding this comment.
oh hmm i see nvm, good catch
There was a problem hiding this comment.
we can prob improve later also. for example, rank startsWith matches for name higher than includes matches for name, if that makes sense.
walmat
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-####
What changed (plus any additional context for devs)
Screen recordings / screenshots
What to test