Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SafeMath in worklets #5781

Merged
merged 36 commits into from
Jun 4, 2024
Merged

Use SafeMath in worklets #5781

merged 36 commits into from
Jun 4, 2024

Conversation

brunobar79
Copy link
Member

@brunobar79 brunobar79 commented May 28, 2024 •
edited
Loading

Fixes APP-1494

What changed (plus any additional context for devs)

  1. Using SafeMath ONLY inside worklet functions where tokens amount are used for
  • operations (mul / div)
  • comparisons (equal, gt, lt, etc)
  1. Removed unused functions for formatting

Screen recordings / screenshots

Screen.Recording.2024-05-30.at.11.31.31.PM.mov

What to test

Number related stuff in swaps.

@brunobar79 brunobar79 changed the title Increments using SafeMath Use SafeMath in worklets May 29, 2024
@brunobar79 brunobar79 marked this pull request as draft May 29, 2024 22:29
@linear Linear
Copy link

linear bot commented May 31, 2024

APP-1494 Look into the problem of Bignumber vs number on the UI thread via reanimated

@brunobar79 brunobar79 force-pushed the @bruno/safemath-impl branch from 1b572b8 to fced72a Compare May 31, 2024 03:30
@brunobar79 brunobar79 marked this pull request as ready for review May 31, 2024 03:30
@brunobar79 brunobar79 mentioned this pull request May 31, 2024
Merged
walmat
walmat approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@walmat walmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty king 🥇

jinchung
jinchung approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@jinchung jinchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@brunobar79 brunobar79 merged commit 8842d80 into develop Jun 4, 2024
6 checks passed
@brunobar79 brunobar79 deleted the @bruno/safemath-impl branch June 4, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walmat walmat walmat approved these changes

@jinchung jinchung jinchung approved these changes

Assignees
No one assigned
Labels
swaps v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brunobar79 @jinchung @walmat