Add analytics #5805
Merged
Add analytics #5805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg-schrammel
approved these changes
Jun 4, 2024
walmat
requested review from
brunobar79,
jinchung,
greg-schrammel and
christianbaroni
brunobar79
reviewed
Jun 11, 2024
There was a problem hiding this comment.
Looks good! Following up on Christian's comments, the takeway is there's certain events where we only want to know the (final) values right at the time execution.
That's enough data to derive stuff like slippage, where we could create a query on the analytics platform to see if people are using a different value than the default, etc.
Same for the search query, the final result is what matter.
benisgold
approved these changes
Jun 11, 2024
BrodyHughes
added a commit
that referenced
this pull request
Jun 13, 2024
…bow into brody/lint-on-pre-commit * 'brody/lint-on-pre-commit' of github.com:rainbow-me/rainbow: Math related fixes (#5837) Hide Flashbots outside of mainnet (#5842) fix getProviderForNetwork type (#5843) Fix isSwapping not being reset (#5840) Swaps: fix crashes, logic and UI fixes (#5839) default to fast suggestion if custom is not set (#5841) guard each entry point into swaps to prevent readonly wallets from accessing it (#5835) Swaps: token list and search improvements (#5834) Add analytics (#5805)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-1233
What changed (plus any additional context for devs)
Adds analytical events to track critical swaps path
Screen recordings / screenshots
What to test