Add entry point for other networks #5824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oesn't make sense since they don't have another asset on that chain
walmat
commented
Jun 6, 2024
| @@ -32,7 +32,7 @@ import { queryClient } from '@/react-query'; | |||
| import { divWorklet, equalWorklet, greaterThanWorklet, mulWorklet, toFixedWorklet } from '@/__swaps__/safe-math/SafeMath'; | |||
|
|
|||
| function getInitialInputValues(initialSelectedInputAsset: ExtendedAnimatedAssetWithColors | null) { | |||
| const initialBalance = Number(initialSelectedInputAsset?.balance.amount) ?? 0; | |||
| const initialBalance = initialSelectedInputAsset ? Number(initialSelectedInputAsset?.balance.amount) : 0; | |||
There was a problem hiding this comment.
This was NaN when no initial inputAsset was set.
walmat
commented
Jun 6, 2024
Comment on lines
+130
to
+132
| const inputProgress = useSharedValue( | ||
| initialSelectedOutputAsset && !initialSelectedInputAsset ? NavigationSteps.TOKEN_LIST_FOCUSED : NavigationSteps.INPUT_ELEMENT_FOCUSED | ||
| ); |
There was a problem hiding this comment.
for cases where we have an output asset but no initial input asset
walmat
commented
Jun 6, 2024
Comment on lines
+152
to
+154
| if (Number(availableBalance) === 0) { | ||
| return 0; | ||
| } |
There was a problem hiding this comment.
this might not be needed with the NaN check I added, but does this hurt anything to have here?
walmat
commented
Jun 6, 2024
walmat
commented
Jun 6, 2024
Comment on lines
+119
to
+121
| } else { | ||
| swapsStore.setState({ inputAsset: null }); | ||
| } |
There was a problem hiding this comment.
@christianbaroni I can remove this, but I noticed for cases where we don't have a largest balance on the same chain we still default to the largest overall balance. Is that intended? My thinking is it'd make more sense for users to explicitly select an asset so that we aren't making an initial quote fetch that they (probably) don't want.
walmat
commented
Jun 6, 2024
Comment on lines
+80
to
+81
| } else { | ||
| swapsStore.setState({ inputAsset: null }); |
There was a problem hiding this comment.
it was happening here too, so i added it here as well
walmat
requested review from
brunobar79,
jinchung,
greg-schrammel,
christianbaroni and
benisgold
greg-schrammel
approved these changes
Jun 9, 2024
Co-authored-by: gregs <[email protected]>
BrodyHughes
added a commit
that referenced
this pull request
Jun 11, 2024
…ap-v2-e2e * 'develop' of github.com:rainbow-me/rainbow: Fix weird issues with rounding (#5822) Fix provider recursion bug, provider function types (#5829) bump braces (#5831) Add entry point for other networks (#5824) remove info icon on max transaction fee row as we don't have that in spec (#5827) [e2e] Add Malicious Dapp interaction test (#5764) reorg ens related calls (#5828) Performance: limit Sentry tracking, fix NFT hooks (#5819) fix wrong chainname (#5823) Disable flashbots toggle on appropriate chains (#5812) add type to SearchAsset type and add into type possibilities (#5820) fix fasterimage border radius android (#5816) more Safemath fixes (#5818)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-1578
What changed (plus any additional context for devs)
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-06-06.at.16.53.21.mp4
Screen recordings / screenshots
What to test