Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swaps: token list and search improvements #5834

Merged
merged 18 commits into from
Jun 12, 2024
Merged

Swaps: token list and search improvements #5834

merged 18 commits into from
Jun 12, 2024

Conversation

christianbaroni
Copy link
Member

Fixes APP-1354
Fixes APP-1528
Fixes APP-1529
Fixes APP-1551
Fixes APP-1554
Fixes APP-1558
Fixes APP-1563

What changed (plus any additional context for devs)

  • Optimizes the input and output token lists
  • Optimizes input and output token search
  • Increases the max number of assets to show in the output lists
  • Fixes surfacing of output token results on other networks
  • Enables cross-network contract address search
  • Fixes the checks that determine whether an asset can be bridged and whether the current swap is a bridge
  • Fixes the output list isNativeAsset checks
  • Adds a swapInfo derived value to the context, which for now contains areBothAssetsSelected and isBridging
  • Fixes all max button issues
  • Fixes uniqueId discrepancies and ensures all address and mainnet_address fields are populated correctly based on the asset networks data
  • Fixes issues with cross-network favorites and the favorite button state in the CoinRow component

Screen recordings / screenshots

RPReplay_Final1718059962.mp4

What to test

@linear Linear
Copy link

linear bot commented Jun 11, 2024

APP-1354 max button HitSlop is being covered by slider

APP-1528 The token list FlashLists each have a ScrollView wrapped around them

APP-1529 Adjust max to sell to accommodate for gas

APP-1551 Token addresses for favorites in swaps aren’t chain specific

APP-1554 Bridge section keeps growing if you keep switching between chains with a bridge asset

APP-1558 Disable max button if max is already input amount

APP-1563 “On Other Networks” results aren’t shown on mainnet

walmat
walmat approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@walmat walmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly just nitpicks. otherwise lgtm! Nice work on the caching search query results btw

@christianbaroni christianbaroni merged commit d9ad21d into develop Jun 12, 2024
6 checks passed
@christianbaroni christianbaroni deleted the @christian/swaps-list-and-search-improvements branch June 12, 2024 03:44
BrodyHughes added a commit that referenced this pull request Jun 13, 2024
@BrodyHughes
Merge branch 'brody/lint-on-pre-commit' of github.com:rainbow-me/rain…
3b1fd6e 
…bow into brody/lint-on-pre-commit

* 'brody/lint-on-pre-commit' of github.com:rainbow-me/rainbow:
  Math related fixes (#5837)
  Hide Flashbots outside of mainnet (#5842)
  fix getProviderForNetwork type (#5843)
  Fix isSwapping not being reset (#5840)
  Swaps: fix crashes, logic and UI fixes (#5839)
  default to fast suggestion if custom is not set (#5841)
  guard each entry point into swaps to prevent readonly wallets from accessing it (#5835)
  Swaps: token list and search improvements (#5834)
  Add analytics (#5805)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walmat walmat walmat approved these changes

@brunobar79 brunobar79 Awaiting requested review from brunobar79

@jinchung jinchung Awaiting requested review from jinchung

@greg-schrammel greg-schrammel Awaiting requested review from greg-schrammel

@benisgold benisgold Awaiting requested review from benisgold

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christianbaroni @walmat