Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[e2e] Manual backup e2e test #5913

Merged
merged 7 commits into from
Jul 26, 2024
Merged

[e2e] Manual backup e2e test #5913

merged 7 commits into from
Jul 26, 2024

Conversation

BrodyHughes
Copy link
Member

@BrodyHughes BrodyHughes commented Jul 2, 2024 •
edited
Loading

What changed (plus any additional context for devs)

  • added coverage for manual wallet backups

What to test

  • does it pass?

walmat
walmat requested changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@walmat walmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Can we target buttons by testID instead of finding them by text? I think this is a little less brittle in case we change i18n later on.

@BrodyHughes
init
97b625c
@BrodyHughes
test file
7ca7d54
@BrodyHughes
Merge branch 'brody/e2e-manual-backup' of github.com:rainbow-me/rainb…
3742c90 
…ow into brody/e2e-manual-backup

* 'brody/e2e-manual-backup' of github.com:rainbow-me/rainbow:
  test file
  init
@BrodyHughes
Copy link
Member Author

/rebase

@github-actions github-actions bot force-pushed the brody/e2e-manual-backup branch from 3742c90 to 7ca7d54 Compare July 22, 2024 16:44
@BrodyHughes BrodyHughes requested a review from walmat July 24, 2024 18:25
@BrodyHughes BrodyHughes merged commit 0f033be into develop Jul 26, 2024
6 checks passed
@BrodyHughes BrodyHughes deleted the brody/e2e-manual-backup branch July 26, 2024 18:09
BrodyHughes added a commit that referenced this pull request Jul 26, 2024
@BrodyHughes
Merge branch 'develop' of github.com:rainbow-me/rainbow into brody/sw…
15e9b05 
…ap-v2-e2e-test-2

* 'develop' of github.com:rainbow-me/rainbow:
  [e2e] Manual backup e2e test (#5913)
  . (#5958)
  Add max swappable amount on balance badge tap (#5947)
  changelog (#5957)
  chore: set referrer for claims (#5954)
  remove FULL_SCREEN_INTENT permission (#5955)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walmat walmat walmat approved these changes

@brunobar79 brunobar79 Awaiting requested review from brunobar79

@jinchung jinchung Awaiting requested review from jinchung

@christianbaroni christianbaroni Awaiting requested review from christianbaroni

@benisgold benisgold Awaiting requested review from benisgold

@greg-schrammel greg-schrammel Awaiting requested review from greg-schrammel

Assignees
No one assigned
Labels
backups v2 e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BrodyHughes @walmat @jinchung