Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tophat #6043

Merged
merged 35 commits into from
Sep 4, 2024
Merged

Tophat #6043

merged 35 commits into from
Sep 4, 2024

Conversation

brunobar79
Copy link
Member

@brunobar79 brunobar79 commented Aug 26, 2024

What changed (plus any additional context for devs)

Splits CI jobs in two parallel.

  • build: which generates a ready to install sim and iPhone build for the current comment in release mode.
  • tests: which runs linting + unit tests in one action, and e2e in another one (also in parallel)

Screen recordings / screenshots

Sim:

Screen.Recording.2024-08-29.at.7.55.48.PM.mov

Device:

Screen.Recording.2024-08-29.at.8.00.27.PM.mov

What to test

  • Install the latest version of tophat.
  • Make sure you have the iPhone 15 pro simulator with iOS 17.4 installed.
  • Make sure you have your phone as a device registered inside xcode (with wifi builds enabled)
  • Select your iPhone on tophat and click on the comment of this PR where it says "device". The app should be installed immediately
  • Select your Sim on tophat and click on the comment of this PR where it says "simulator". The app should be installed immediately

@brunobar79 brunobar79 closed this Aug 27, 2024
@brunobar79 brunobar79 reopened this Aug 27, 2024
@brunobar79 brunobar79 marked this pull request as ready for review August 29, 2024 23:48
@brunobar79 brunobar79 changed the title [DO NOT MERGE] Tophat test Tophat Aug 29, 2024
@brunobar79 brunobar79 force-pushed the @bruno/publish-artifacts branch from 39962e4 to 8df8612 Compare August 30, 2024 22:24
@brunobar79
Copy link
Member Author

Launch in simulator or device for 2a5fb51

Copy link
Member

@jinchung jinchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@jinchung jinchung merged commit 2a9b11d into develop Sep 4, 2024
8 checks passed
@jinchung jinchung deleted the @bruno/publish-artifacts branch September 4, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants