Zeego MintsFilter migration #6126
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walmat
commented
Sep 24, 2024
| @@ -30,6 +30,7 @@ module.exports = function (api) { | |||
| root: ['./src'], | |||
| }, | |||
| ], | |||
| '@babel/plugin-transform-export-namespace-from', | |||
There was a problem hiding this comment.
This was in order to get the expo modules to work nicely. See: dominicstop/react-native-ios-context-menu#81 (comment)
walmat
commented
Sep 24, 2024
There was a problem hiding this comment.
This includes basic functionality for Dropdowns with titles and components. Will add submenus in a follow-up PR.
walmat
changed the title
nandorojo
reviewed
Sep 25, 2024
| sideOffset={sideOffset} | ||
| collisionPadding={12} | ||
| > | ||
| {menuConfig.menuTitle && ( |
There was a problem hiding this comment.
this will crash if someone passes an empty string btw
benisgold
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-1510
Fixes APP-1797
Fixes APP-1691
What changed (plus any additional context for devs)
There is a lot of noise in this PR because of the need for Expo Modules for
react-native-ios-context-menu.This PR adds the initial work of implementing Zeego dropdown menus. We're doing this to provide consistency between iOS and Android when it comes to dropdown menus. Right now we're using ActionSheets a lot on Android and incrementally we are hoping to reduce that number down to zero.
For this PR, we are adding one entry point in the MintsFilter Menu component.
Screen recordings / screenshots
iOS
Android
// coming soon
What to test
test that all other context menus are unaffected and the mints filter still works