Wallet Switcher v2 #6318
Wallet Switcher v2 #6318
Conversation
…dropdown component
| if (data !== undefined) { | ||
| (onPressMenuItem as (actionKey: T, data: U) => void)(actionKey, data); | ||
| } else { | ||
| (onPressMenuItem as (actionKey: T) => void)(actionKey); | ||
| } |
There was a problem hiding this comment.
Great animation! Unrelated to this PR, but just popped into my head. We should come up with a strategy for reducing animations when a user has Accessibility > Reduced Motion toggled to on.
There was a problem hiding this comment.
I believe reanimated handles the reduced motion system setting by default: https://docs.swmansion.com/react-native-reanimated/docs/guides/accessibility/
| const MenuItemComponent = menuItemType === 'checkbox' ? DropdownMenuCheckboxItem : DropdownMenuItem; | ||
|
|
There was a problem hiding this comment.
I'm actually not sure we ever need to use the bare DropdownMenuItem. Can't we optimistically assume it's a DropdownMenuCheckboxItem and just not show the checkmark by setting value={undefined}? Unsure, but worth trying if it simplifies this
There was a problem hiding this comment.
On Android an empty checkbox gets automatically added when using the DropdownMenuCheckboxItem. The value prop is required for DropdownMenuCheckboxItem and can't be set to undefined. I could change it to assume undefined value types should use the other component, but I don't think there is a way tot get around needing to conditionally use the DropdownMenuCheckboxItem or DropdownMenuItem
| return ( | ||
| <Animated.ScrollView | ||
| // eslint-disable-next-line react/jsx-props-no-spreading | ||
| {...props} | ||
| /> | ||
| ); | ||
| }} | ||
| viewabilityConfig={{ itemVisiblePercentThreshold: 50 }} | ||
| // viewabilityConfig={{ itemVisiblePercentThreshold: 50 }} |
There was a problem hiding this comment.
Yeah this component actually isn't used at all, and if you wanted to use it with the viewability exposed properly there would need to be some more work so just commented out to better indicate that
|
#nitpick but the snapping back to origin seems slow to me and the spring seems spongy. |
|
Not sure if intentional, but I had 2 wallets that weren't read only, and 2 that were, and only 2 wallets got pinned. |
|
Only blocker, total wallet balance at the bottom for me is |
|
Fixes APP-2081
Spec: https://www.notion.so/135b001b85b4808cae11f62380e8fc5c
What changed (plus any additional context for devs)
DraggableScrollViewand theuseDraggableScrollhook that handles auto scrolling when dragging items at the visible edge of the scroll.DraggableGridto fix bug related to offsets drifting when interacting too quickly with different draggable items. This fix needs to also be applied to theDraggableScrollViewbut it would currently break auto scrollingChangeWalletSheet,WalletList, andAddressRowPinnedWalletsGridfor the grid of up to 6 pinned wallets.pinnedWalletsStoreDropdownMenucomponent to be usable for non checkmark type itemsFeatureHintTooltipfor general feature hints, API loosely based on Radix Tooltip component.Review Notes
ChangeWalletSheetrelated to removing, editing, etc. a wallet did not change.Known Issues
Potential follow up improvements
AddressRowlayout transitions can be smoothly animatedDndProvidercurrently does some custom handling of the pan gesture starting, which it should not. This is the source of some issues where pressing on the item gives haptic feedback indicating its ready to drag but it cannot be dragged because the gesture actually failed.Screen recordings / screenshots
RPReplay_Final1734630484.MP4
What to test