-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inkchain support #6323
Merged
Merged
Add inkchain support #6323
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
689777f
add basic entries
walmat dad7546
update chain badge assets
walmat ee246bc
alphabetizing imports / mappings
walmat 27c7cf0
update tokenSearch, default bips
walmat 342b404
alphabetize and clean up
walmat 43b7f52
alphabetize en_US
walmat b8b29e7
chore: merge
walmat 246177c
add explainer text and colors
walmat 6e318e0
update simplehash networks
walmat e551da9
update chainIds and explainer copy
walmat cb0884d
chain IDs
walmat d1111ab
add proper colors
walmat 9ed1369
add badges I have access to
walmat 0112746
add assets to assets folder as well
walmat 4292675
add assets
walmat f3a5220
comment out other chains
walmat 64b4777
remove badges for other networks
walmat 8961150
fix ethereum badge assets
walmat d6edb40
idk if podlock is needed
walmat 6ebb8ac
Merge branch 'develop' of github.com:rainbow-me/rainbow into @matthew…
brunobar79 fe402b7
Readd avalanche network type
jinchung 31865f1
Add new chains to chainsIdByNetwork mapping
jinchung File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file modified
BIN
+23 Bytes
(100%)
ios/Images.xcassets/badges/apechainBadge.imageset/apechainBadge.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-53 Bytes
(99%)
ios/Images.xcassets/badges/apechainBadge.imageset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-176 Bytes
(99%)
ios/Images.xcassets/badges/apechainBadge.imageset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-2.2 KB
(68%)
ios/Images.xcassets/badges/apechainBadgeLarge.imageset/apechainBadgeLarge.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-7.42 KB
(62%)
ios/Images.xcassets/badges/apechainBadgeLarge.imageset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-16.3 KB
(57%)
ios/Images.xcassets/badges/apechainBadgeLarge.imageset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.72 KB
(70%)
...ages.xcassets/badges/apechainBadgeLargeDark.imageset/apechainBadgeLargeDark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-5.84 KB
(64%)
...s.xcassets/badges/apechainBadgeLargeDark.imageset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-13.1 KB
(59%)
...s.xcassets/badges/apechainBadgeLargeDark.imageset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+87 Bytes
(100%)
ios/Images.xcassets/badges/ethereum.imageset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+126 Bytes
(100%)
ios/Images.xcassets/badges/ethereum.imageset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.08 KB
(220%)
ios/Images.xcassets/badges/ethereumBadge.imageset/ethereumBadge.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+2.66 KB
(220%)
ios/Images.xcassets/badges/ethereumBadge.imageset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+4.62 KB
(220%)
ios/Images.xcassets/badges/ethereumBadge.imageset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion
2
ios/Images.xcassets/badges/ethereumBadgeDark.imageset/Contents.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file removed
BIN
-917 Bytes
ios/Images.xcassets/badges/ethereumBadgeDark.imageset/ethereumBadgeDark-1.png
Binary file not shown.
Binary file added
BIN
+2.48 KB
ios/Images.xcassets/badges/ethereumBadgeDark.imageset/ethereumBadgeDark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+4.48 KB
(380%)
ios/Images.xcassets/badges/ethereumBadgeDark.imageset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+8.89 KB
(480%)
ios/Images.xcassets/badges/ethereumBadgeDark.imageset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
23 changes: 23 additions & 0 deletions
23
ios/Images.xcassets/badges/ethereumBadgeLarge.imageset/Contents.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
{ | ||
"images" : [ | ||
{ | ||
"filename" : "ethereumBadgeLarge.png", | ||
"idiom" : "universal", | ||
"scale" : "1x" | ||
}, | ||
{ | ||
"filename" : "[email protected]", | ||
"idiom" : "universal", | ||
"scale" : "2x" | ||
}, | ||
{ | ||
"filename" : "[email protected]", | ||
"idiom" : "universal", | ||
"scale" : "3x" | ||
} | ||
], | ||
"info" : { | ||
"author" : "xcode", | ||
"version" : 1 | ||
} | ||
} |
Binary file added
BIN
+4.85 KB
ios/Images.xcassets/badges/ethereumBadgeLarge.imageset/ethereumBadgeLarge.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+13.2 KB
ios/Images.xcassets/badges/ethereumBadgeLarge.imageset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+24.9 KB
ios/Images.xcassets/badges/ethereumBadgeLarge.imageset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
23 changes: 23 additions & 0 deletions
23
ios/Images.xcassets/badges/ethereumBadgeLargeDark.imageset/Contents.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
{ | ||
"images" : [ | ||
{ | ||
"filename" : "ethereumBadgeLargeDark.png", | ||
"idiom" : "universal", | ||
"scale" : "1x" | ||
}, | ||
{ | ||
"filename" : "[email protected]", | ||
"idiom" : "universal", | ||
"scale" : "2x" | ||
}, | ||
{ | ||
"filename" : "[email protected]", | ||
"idiom" : "universal", | ||
"scale" : "3x" | ||
} | ||
], | ||
"info" : { | ||
"author" : "xcode", | ||
"version" : 1 | ||
} | ||
} |
Binary file added
BIN
+4.42 KB
...ages.xcassets/badges/ethereumBadgeLargeDark.imageset/ethereumBadgeLargeDark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+11.5 KB
...s.xcassets/badges/ethereumBadgeLargeDark.imageset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+21.5 KB
...s.xcassets/badges/ethereumBadgeLargeDark.imageset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
23 changes: 23 additions & 0 deletions
23
ios/Images.xcassets/badges/ethereumBadgeNoShadow.imageset/Contents.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
{ | ||
"images" : [ | ||
{ | ||
"filename" : "ethereumBadgeNoShadow.png", | ||
"idiom" : "universal", | ||
"scale" : "1x" | ||
}, | ||
{ | ||
"filename" : "[email protected]", | ||
"idiom" : "universal", | ||
"scale" : "2x" | ||
}, | ||
{ | ||
"filename" : "[email protected]", | ||
"idiom" : "universal", | ||
"scale" : "3x" | ||
} | ||
], | ||
"info" : { | ||
"author" : "xcode", | ||
"version" : 1 | ||
} | ||
} |
Binary file added
BIN
+1.18 KB
...Images.xcassets/badges/ethereumBadgeNoShadow.imageset/ethereumBadgeNoShadow.png
Oops, something went wrong.
Binary file added
BIN
+2.22 KB
...ges.xcassets/badges/ethereumBadgeNoShadow.imageset/[email protected]
Oops, something went wrong.
Binary file added
BIN
+3.47 KB
...ges.xcassets/badges/ethereumBadgeNoShadow.imageset/[email protected]
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
{ | ||
"images" : [ | ||
{ | ||
"filename" : "ink.png", | ||
"idiom" : "universal", | ||
"scale" : "1x" | ||
}, | ||
{ | ||
"filename" : "[email protected]", | ||
"idiom" : "universal", | ||
"scale" : "2x" | ||
}, | ||
{ | ||
"filename" : "[email protected]", | ||
"idiom" : "universal", | ||
"scale" : "3x" | ||
} | ||
], | ||
"info" : { | ||
"author" : "xcode", | ||
"version" : 1 | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
23 changes: 23 additions & 0 deletions
23
ios/Images.xcassets/badges/inkBadge.imageset/Contents.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
{ | ||
"images" : [ | ||
{ | ||
"filename" : "inkBadge.png", | ||
"idiom" : "universal", | ||
"scale" : "1x" | ||
}, | ||
{ | ||
"filename" : "[email protected]", | ||
"idiom" : "universal", | ||
"scale" : "2x" | ||
}, | ||
{ | ||
"filename" : "[email protected]", | ||
"idiom" : "universal", | ||
"scale" : "3x" | ||
} | ||
], | ||
"info" : { | ||
"author" : "xcode", | ||
"version" : 1 | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
23 changes: 23 additions & 0 deletions
23
ios/Images.xcassets/badges/inkBadgeDark.imageset/Contents.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
{ | ||
"images" : [ | ||
{ | ||
"filename" : "inkBadgeDark.png", | ||
"idiom" : "universal", | ||
"scale" : "1x" | ||
}, | ||
{ | ||
"filename" : "[email protected]", | ||
"idiom" : "universal", | ||
"scale" : "2x" | ||
}, | ||
{ | ||
"filename" : "[email protected]", | ||
"idiom" : "universal", | ||
"scale" : "3x" | ||
} | ||
], | ||
"info" : { | ||
"author" : "xcode", | ||
"version" : 1 | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
23 changes: 23 additions & 0 deletions
23
ios/Images.xcassets/badges/inkBadgeLarge.imageset/Contents.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
{ | ||
"images" : [ | ||
{ | ||
"filename" : "inkBadgeLarge.png", | ||
"idiom" : "universal", | ||
"scale" : "1x" | ||
}, | ||
{ | ||
"filename" : "[email protected]", | ||
"idiom" : "universal", | ||
"scale" : "2x" | ||
}, | ||
{ | ||
"filename" : "[email protected]", | ||
"idiom" : "universal", | ||
"scale" : "3x" | ||
} | ||
], | ||
"info" : { | ||
"author" : "xcode", | ||
"version" : 1 | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
23 changes: 23 additions & 0 deletions
23
ios/Images.xcassets/badges/inkBadgeLargeDark.imageset/Contents.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
{ | ||
"images" : [ | ||
{ | ||
"filename" : "inkBadgeLargeDark.png", | ||
"idiom" : "universal", | ||
"scale" : "1x" | ||
}, | ||
{ | ||
"filename" : "[email protected]", | ||
"idiom" : "universal", | ||
"scale" : "2x" | ||
}, | ||
{ | ||
"filename" : "[email protected]", | ||
"idiom" : "universal", | ||
"scale" : "3x" | ||
} | ||
], | ||
"info" : { | ||
"author" : "xcode", | ||
"version" : 1 | ||
} | ||
} |
Binary file added
BIN
+3.22 KB
ios/Images.xcassets/badges/inkBadgeLargeDark.imageset/inkBadgeLargeDark.png
Oops, something went wrong.
Binary file added
BIN
+8.53 KB
ios/Images.xcassets/badges/inkBadgeLargeDark.imageset/[email protected]
Oops, something went wrong.
Binary file added
BIN
+15.5 KB
ios/Images.xcassets/badges/inkBadgeLargeDark.imageset/[email protected]
Oops, something went wrong.
23 changes: 23 additions & 0 deletions
23
ios/Images.xcassets/badges/inkBadgeNoShadow.imageset/Contents.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
{ | ||
"images" : [ | ||
{ | ||
"filename" : "inkBadgeNoShadow.png", | ||
"idiom" : "universal", | ||
"scale" : "1x" | ||
}, | ||
{ | ||
"filename" : "[email protected]", | ||
"idiom" : "universal", | ||
"scale" : "2x" | ||
}, | ||
{ | ||
"filename" : "[email protected]", | ||
"idiom" : "universal", | ||
"scale" : "3x" | ||
} | ||
], | ||
"info" : { | ||
"author" : "xcode", | ||
"version" : 1 | ||
} | ||
} |
Binary file added
BIN
+822 Bytes
ios/Images.xcassets/badges/inkBadgeNoShadow.imageset/inkBadgeNoShadow.png
Oops, something went wrong.
Binary file added
BIN
+1.04 KB
ios/Images.xcassets/badges/inkBadgeNoShadow.imageset/[email protected]
Oops, something went wrong.
Binary file added
BIN
+1.25 KB
ios/Images.xcassets/badges/inkBadgeNoShadow.imageset/[email protected]
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,74 @@ | ||
#!/bin/bash | ||
|
||
# Prompt for network details | ||
read -p "Enter the network name (case sensitive): " networkName | ||
read -p "Enter the chain ID (number): " chainId | ||
read -p "Enter the light mode color (hex): " lightColor | ||
read -p "Enter the dark mode color (hex): " darkColor | ||
|
||
# Create imagesets | ||
mkdir -p "ios/Images.xcassets/badges/${networkName}.imageset" | ||
mkdir -p "ios/Images.xcassets/badges/${networkName}Badge.imageset" | ||
mkdir -p "ios/Images.xcassets/badges/${networkName}BadgeDark.imageset" | ||
mkdir -p "ios/Images.xcassets/badges/${networkName}BadgeLarge.imageset" | ||
mkdir -p "ios/Images.xcassets/badges/${networkName}BadgeLargeDark.imageset" | ||
mkdir -p "ios/Images.xcassets/badges/${networkName}BadgeNoShadow.imageset" | ||
|
||
# Create Contents.json for each imageset | ||
for suffix in "" "Badge" "BadgeDark" "BadgeLarge" "BadgeLargeDark" "BadgeNoShadow"; do | ||
cat > "ios/Images.xcassets/badges/${networkName}${suffix}.imageset/Contents.json" << EOF | ||
{ | ||
"images" : [ | ||
{ | ||
"filename" : "${networkName}${suffix}.png", | ||
"idiom" : "universal", | ||
"scale" : "1x" | ||
}, | ||
{ | ||
"filename" : "${networkName}${suffix}@2x.png", | ||
"idiom" : "universal", | ||
"scale" : "2x" | ||
}, | ||
{ | ||
"filename" : "${networkName}${suffix}@3x.png", | ||
"idiom" : "universal", | ||
"scale" : "3x" | ||
} | ||
], | ||
"info" : { | ||
"author" : "xcode", | ||
"version" : 1 | ||
} | ||
} | ||
EOF | ||
done | ||
|
||
# Update en_US.json | ||
# Using perl for more precise JSON manipulation | ||
perl -i -0pe 's/("explain":\s*{)/$1\n "'$networkName'": {\n "text": "",\n "title": "What'\''s '$networkName'?"\n },/m' src/languages/en_US.json | ||
|
||
# Update types.ts | ||
# Add to Network enum | ||
sed -i '' "/export enum Network {/a\\ | ||
${networkName} = '${networkName}', | ||
" src/chains/types.ts | ||
|
||
# Add to ChainId enum | ||
sed -i '' "/export enum ChainId {/a\\ | ||
${networkName} = ${chainId}, | ||
" src/chains/types.ts | ||
|
||
# Update colors.ts for light mode - look for the first networkColors declaration | ||
sed -i '' "/^ let networkColors = {/a\\ | ||
[ChainId.${networkName}]: '${lightColor}', | ||
" src/styles/colors.ts | ||
|
||
# Update colors.ts for dark mode - look specifically in the darkMode if block | ||
sed -i '' "/if (darkMode) {/,/^ }/ { | ||
/networkColors = {/a\\ | ||
[ChainId.${networkName}]: '${darkColor}', | ||
}" src/styles/colors.ts | ||
|
||
echo "Network ${networkName} has been added!" | ||
echo "Note: You'll need to add the actual badge images to the imageset directories" | ||
echo "Don't forget to run prettier to format the modified files" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this bump had a few chains we needed