-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chain Badge consolidation & backend delivery #6328
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* start work on converting existing chain selection dropdowns to Zeego * available networks v2 convert * add token icons to claim dropdown and fix but with AvailableNetworks not showing ever * latest changes to try to get hitslop to work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug fixes all look good on both OS's, QA Passed ✅
Waiting to merge until @christianbaroni introduces a few positioning changes to the ChainImage component |
WHEN REVIEWING FILES, MAKE SURE YOU FILTER OUR .png / .json FILES
Blocked until #6344 lands as we currently rely on local ios imagesets for chain selectors.
What changed (plus any additional context for devs)
1. Badge System Refactoring
Changes to Chain Badge Implementation
ios/Images.xcassets/badges/
ChainBadge
component with newChainImage
componentgetChainsBadge()
method tobackendNetworksStore
to manage badge URLsComponent Updates
ChainBadge
orEthCoinIcon
to use the newChainImage
component, including:WalletConnectApprovalSheet
TransactionDetailsValueAndFeeSection
MintSheet
ClaimCustomization
FastTransactionCoinRow
2. Image Caching Improvements
FastImage Integration
clearImageCache
function in DevSection to clear both ImgixImage and FastImage caches3. Menu System Updates
Dropdown Menu Refactoring
DropdownMenu
toClaimableMenu
in claimables section4. UI/UX Improvements
Chain Badge Positioning
Component Cleanup
This PR represents a significant refactoring of the chain badge system, moving from static assets to remote images while improving the overall architecture and maintainability of the codebase.
Screen recordings / screenshots
// wip
What to test
TestFlight:
1.9.50 (3)
https://www.notion.so/rainbowdotme/App-Chain-Image-QA-Checklist-15fb001b85b480839cb1e0cf1665de12