-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expanded state v2 phase 1 #6332
Conversation
…@benisgold/expanded-state-phase-1
…@benisgold/expanded-state-phase-1
…@benisgold/expanded-state-phase-1
…m/rainbow-me/rainbow into @benisgold/expanded-state-phase-1
Should be fixed in latest build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is gorgeous stuff 👨🎨
Kane and I spoke off gh regarding a couple small issues.
the first Kane addressed here: https://www.loom.com/share/10a11004ea084793a2b63809316dafca
i left a couple small qs on the code itself, but none are blocking 🚢
…min if user settings currency is eth
Fixes APP-2097, APP-2088, APP-2092, APP-2096, APP-2091
What changed (plus any additional context for devs)
Initial work on expanded states v2 feature including:
Other changes
TextShadow
componentDropdownMenu
componentformatDate
utilTesting Notes
Future improvements / follow ups
useChartInfo
anduseExternalToken
to use the new query storeScreen recordings / screenshots
RPReplay_Final1737599042.MP4
What to test
Click into token expanded state from main screen assets, trending tokens, and discover search.