Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support only persisting when search query is undefined (the default lists) #6335

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Support only persisting when search query is undefined (the default lists) #6335

merged 2 commits into from
Dec 20, 2024

Conversation

jinchung
Copy link
Member

@jinchung jinchung commented Dec 16, 2024 •
edited
Loading

Fixes APP-2163

What changed (plus any additional context for devs)

  • We DO want to persist the initial result list (per network)
  • We don't want to persist the results of search when you type something

Screen recordings / screenshots

  • After loading the default lists for a network, killing the app and coming back to search should still show default lists
ScreenRecording_12-16-2024.14-10-16_1.MP4
  • After typing in a search query, closing swap (not killing the app) and searching for the same query should be quick
ScreenRecording_12-16-2024.14-11-00_1.MP4

What to test

  • Testing situations below can happen after installing the TF after having prod version installed (no need to delete the app in between)
  • After loading the default lists for a network, killing the app and coming back to search should still show default lists
  • After typing in a search query, closing swap (not killing the app) and searching for the same query should be quick
  • After typing in a search query, killing the app, it should still load and search the results (but not preloaded from local cache; this might be difficult to see; you may see a little spot where it goes empty and then fills with data)

@linear Linear
Copy link

linear bot commented Dec 16, 2024

APP-2163 [Search] Revisit persistence of search data

@jinchung jinchung requested review from derHowie and benisgold and removed request for benisgold December 16, 2024 20:08
@jinchung jinchung marked this pull request as ready for review December 16, 2024 20:08
@brunobar79
Copy link
Member

Launch in simulator or device for a4d0858

derHowie
derHowie approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@derHowie derHowie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@brunobar79 brunobar79 merged commit b86910e into develop Dec 20, 2024
6 checks passed
@brunobar79 brunobar79 deleted the @jin/search-persist branch December 20, 2024 16:45
@brunobar79 brunobar79 added the release for release blockers and release candidate branches label Dec 20, 2024
@brunobar79
Copy link
Member

Launch in simulator or device for 34dded5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derHowie derHowie derHowie approved these changes

@brunobar79 brunobar79 brunobar79 approved these changes

Assignees
No one assigned
Labels
release for release blockers and release candidate branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jinchung @brunobar79 @derHowie