Convert networkColors to backendNetworks
#6353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walmat
commented
Dec 19, 2024
| @@ -14,7 +14,7 @@ const STALE_TIME = 10000; | |||
|
|
|||
| async function fetchAccountENSDomains({ accountAddress }: { accountAddress: string }) { | |||
| const result = await fetchAccountDomains(accountAddress); | |||
| if (!result.account) return []; | |||
| if (!result?.account) return []; | |||
There was a problem hiding this comment.
this fixed the [TypeError: Cannot read property 'account' of undefined]
maxbbb
approved these changes
Dec 20, 2024
| @@ -9,6 +9,7 @@ import { IS_TEST } from '@/env'; | |||
| import { BackendNetwork, BackendNetworkServices, chainHardhat, chainHardhatOptimism, ChainId } from '@/state/backendNetworks/types'; | |||
| import { GasSpeed } from '@/__swaps__/types/gas'; | |||
| import { useConnectedToHardhatStore } from '@/state/connectedToHardhat'; | |||
| import { colors as globalColors } from '@/styles'; | |||
There was a problem hiding this comment.
Small and unimportant, but given there is an export from the @/design-system called globalColors, but you do have to rename colors to something else here, something like themeColors might be less confusing
benisgold
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed (plus any additional context for devs)
Converts the ExplainSheet to use the network color from the backendNetworks. I noticed that these actually aren't used anywhere currently, but in case we want to add these explainers again they can be delivered from backend networks.
Also noticed an annoying
[TypeError: Cannot read property 'account' of undefined]log that I fixed in the ENS hooksScreen recordings / screenshots
What to test
nothing really worth testing here.